Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org,
        make-wifi-fast@lists.bufferbloat.net, ath10k@lists.infradead.org,
        John Crispin <john@phrozen.org>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Felix Fietkau <nbd@nbd.name>, Kan Yan <kyan@google.com>,
        Rajkumar Manoharan <rmanohar@codeaurora.org>,
        Kevin Hayes <kevinhayes@google.com>
Subject: Re: [PATCH v6 3/4] mac80211: Implement Airtime-based Queue Limit (AQL)
In-Reply-To: <1a2eb096119c9029e67caf797564d6511c8803a7.camel@sipsolutions.net>
References: <157182473951.150713.7978051149956899705.stgit@toke.dk> <157182474287.150713.12867638269538730397.stgit@toke.dk> <1a2eb096119c9029e67caf797564d6511c8803a7.camel@sipsolutions.net>
Date:   Fri, 08 Nov 2019 11:56:34 +0100
Message-ID: <87a796fxgd.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Johannes Berg <johannes@sipsolutions.net> writes:

> On Wed, 2019-10-23 at 11:59 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote=
:
>>=20
>> =20
>> +void ieee80211_sta_update_pending_airtime(struct ieee80211_local *local=
,
>> +=09=09=09=09=09  struct sta_info *sta, u8 ac,
>> +=09=09=09=09=09  u16 tx_airtime, bool tx_completed)
>> +{
>> +=09spin_lock_bh(&local->active_txq_lock[ac]);
>> +=09if (tx_completed) {
>> +=09=09if (sta) {
>> +=09=09=09if (WARN_ONCE(sta->airtime[ac].aql_tx_pending < tx_airtime,
>> +=09=09=09=09      "TXQ pending airtime underflow: %u, %u",
>> +=09=09=09=09      sta->airtime[ac].aql_tx_pending, tx_airtime))
>
> Maybe add the STA/AC to the message?

Can do. Any idea why we might be seeing underflows (as Kan reported)?

-Toke