Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To:     Johannes Berg <johannes@sipsolutions.net>
CC:     Tamizh chelvam <tamizhr@codeaurora.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCHv8 0/6] cfg80211/mac80211: Add support for TID specific
 configuration
Thread-Topic: [PATCHv8 0/6] cfg80211/mac80211: Add support for TID specific
 configuration
Thread-Index: AQHVk9Zp+IDFjvKhwUy86pHdyrrRoqeBOWSA///PyYCAAFrzAP//0eKAgAA92AA=
Date:   Fri, 8 Nov 2019 16:01:27 +0000
Message-ID: <20191108160121.tbatmqwx64aoqqai@bars>
References: <1572957714-16085-1-git-send-email-tamizhr@codeaurora.org>
 <20191108093207.uv4j44xpm2qvtsv5@bars>
 <84ca3a8b61757360ab9898afcdd3f2f63c770f86.camel@sipsolutions.net>
 <20191108120504.ptl25hacxcftb7tw@bars>
 <1c553c457024b295c7d0a6b118c3848eec28bcbd.camel@sipsolutions.net>
In-Reply-To: <1c553c457024b295c7d0a6b118c3848eec28bcbd.camel@sipsolutions.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [195.182.157.78]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ccc58208-9345-4cd7-98a2-08d76464e961
x-ms-traffictypediagnostic: SN6PR05MB5309:|CY4PR05MB3461:
x-microsoft-antispam-prvs: <SN6PR05MB5309048E0B0F204B4E620064A37B0@SN6PR05MB5309.namprd05.prod.outlook.com>
x-moderation-data: 11/8/2019 4:01:39 PM
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0215D7173F
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(376002)(366004)(136003)(396003)(346002)(39850400004)(199004)(189003)(33716001)(8936002)(386003)(6436002)(486006)(66066001)(71200400001)(81156014)(71190400001)(6506007)(476003)(6246003)(7736002)(256004)(6512007)(2906002)(316002)(54906003)(66946007)(446003)(11346002)(6486002)(9686003)(66446008)(436003)(66476007)(66556008)(64756008)(305945005)(26005)(14454004)(52116002)(86362001)(4326008)(99286004)(186003)(25786009)(102836004)(478600001)(6116002)(8676002)(1076003)(6916009)(81166006)(76176011)(3846002)(5660300002)(229853002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR05MB3461;H:CY4PR05MB3077.namprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: quantenna.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: zAhjUGVnvY0//dm/o9NR87xJOgPqAW6mSMiepRE808K2urH5h9cDdp8DrQ2+JYwccrCGL2OXGqn27OR7QIRt3r2HSokMrS5Gmj2YbmAOzMq0xsKBTNjd0Zpj4WD9zo/zlZuZtuCCnPC7fxjGKcQ68S6HV7VzEZUfiD9sdECnOlHnIHomfkwEOfUY+ZMLvl3M7tzLRIUxnFaEL7x1M1XtVh2JgnoHFVwhKQ2l2VPKwOZGmSxLnuM8PfAmXzjAOOQm2k+fHN/lClsMKMgwA1eELrErDBiD4BP8DEgp6y2ZC6dEbOIPnznDOH9iVHBhfHM+vM3/FKBcJqnkxPfLqIJ5jUtMFvoBtTyvPua6Vpx+NIV/Uuhwpu2d7waBrvwrLPAfYlD5LmBTWz6SZ42lMp890L1zRu2zS1WNOA2NNSIO79O4mkZW6cpEYrnCYgWxiJN/
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <668FE59510DBB34CA2D07D2E9C7A944E@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: quantenna.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ccc58208-9345-4cd7-98a2-08d76464e961
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a355dbce-62b4-4789-9446-c1d5582180ff
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6HeIcXwlE9kocRJISGIR17bvIzQFyLYRyeLviwZKKvBD8chqNftfZA42wZON+M5b0njEeZs/LushrADnWJLkJO3mU9KGCFMqrvAgSk8viAHfw6H3+JV3QPCv9iI/X5t7eupCq4gqF03nQR9oT74YoYtorlB2EJ5y6DOIU1IafpjHSytVrBsd+q62YCtRsuN3B3htn+G1AtBgwky5aVTW+yrds/vKPBn6RLjpaOMxW5M=
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2019 16:01:59.8032
 (UTC)
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR05MB3461
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572
 definitions=2019-11-08_05:2019-11-08,2019-11-08 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 priorityscore=1501
 suspectscore=0 impostorscore=0 mlxlogscore=999 phishscore=0 bulkscore=0
 mlxscore=0 clxscore=1015 adultscore=0 malwarescore=0 lowpriorityscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000
 definitions=main-1911080159
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

> > > @NL80211_TID_CONFIG_ATTR_OVERRIDE: flag attribute, valid only if no S=
TA
> > > 	is selected, if set indicates that the new configuration
> > > 	overrides all previous STA configurations, otherwise previous
> > > 	STA-specific configurations should be left untouched
> > >=20
> > > You also raise a good point wrt. "all TIDs" - but then we should
> > > probably just remove NL80211_TID_CONFIG_ATTR_TID and add a new
> > > NL80211_TID_CONFIG_ATTR_TIDS as a bitmap? OTOH, it's not hard to just
> > > explicitly spell out all TIDs either, I guess, just makes the message=
 a
> > > bit bigger.
> >=20
> > The idea with bitmask for TIDs looks good. It eliminates the need for b=
oth
> > 'all TIDs' define and additional attribute NL80211_TID_CONFIG_ATTR_OVER=
RIDE.
>=20
> I think we still need NL80211_TID_CONFIG_ATTR_OVERRIDE in some way
> (maybe only as a flag attribute), since you could have
>=20
>  * change all stations (some subset of TIDs) *including* already
>    configured stations
>  * or *excluding* already configured stations

Hmmm... Logic is straightforwad without this flag:
- settings are applied to bitmasked TIDs of a single peer if address is spe=
cifed
- settings are applied to bitmasked TIDs of all the peers if no address is =
specified

It looks like you want to infer too much from a single flag. Why keep this =
logic in
cfg80211/mac80211/driver ?

> > In fact, almost no changes are needed for the patch, mostly comments ne=
ed
> > to be updated. Manual typing in iw will be less convenient, but I guess
> > this interface is not supposed to be used by humans after all...
>=20
> If that's a concern we can parse a list in iw, e.g. "0,1,2,3" instaed of
> "0xf", right?

Oh, right, it can be that simple. But this is by no means a concern.

Regards,
Sergey