Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp2948436ybx; Fri, 8 Nov 2019 11:43:05 -0800 (PST) X-Google-Smtp-Source: APXvYqydcBvlKe0UIZ+xzzMpyiibc9tdrxMZ/PiUwGBAVYbh7cu+lsTHjC5/nLwY9QmU2aKetlzw X-Received: by 2002:a17:906:5448:: with SMTP id d8mr10335579ejp.79.1573242185633; Fri, 08 Nov 2019 11:43:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573242185; cv=none; d=google.com; s=arc-20160816; b=0ulXkBAex4QBFeFkcBg2qWdbIazvNQZlfPiUTEdK2oUcpOKmPgUayB+Q74vQ3AtcJW cyb/sixb38IyCofAs3HZZGkGOAu6x7lF15iLJymup7OH8QaaSdTFzCZVUGJado6THFQQ QxiLx+iDhBfzeONPb5eIUK14utYIjL641KJ/DGJhyZoxJpkgPM9bwi/mmzp0psZgr2sy 5HnVCnjTIcqHj8KeDJbvjkeHOYqSMz2NhnOqOmHOK1DqFAfESurbekOwC9JGpuXrOQ5e 1VOhk40HXrXa/CkysDwrBl9yF+z+sFlQejKGQ6NGh0gwtPnWBtXl7BgD6E/1S7bw92LT EyGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=VQP82DdsNyYLgbFy5SoVPe8egj6poHzILIDQC9Av9bM=; b=tZZyxGxED0Qn4gPi4Apoee28TwPh9LFC2NG66saiqR/P9XnU4PKEQrlI2IWXhERfMc rIGdhR3Zqm5V2uQww8k18H5d+Vlfr6LqMQSxyGS8R8BDtGp7oAPxqcj9Yh1yCWzL1HIA vU5jWNm3DyKRwKunoPrZLKRN3DVKhioWq0uL0U0Q6xCPb8WioHsiaH7sQDVT5oSydvio LSdXKjfG9uA20lHJ6hzPLq0CLKgyohXrtXETOlxdxlebu1HpwC9mdtuT4PoGgV1D/fVR Q+cqjjsOrys89R/Dzjopi37+wNp/BNwwKdySAp7dM93UQqWs17cbmPUzbcccBRQ4L9KQ x2gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=NmtTIL7x; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b2si4423929eja.89.2019.11.08.11.42.41; Fri, 08 Nov 2019 11:43:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=NmtTIL7x; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732241AbfKHTm1 (ORCPT + 99 others); Fri, 8 Nov 2019 14:42:27 -0500 Received: from mail2.candelatech.com ([208.74.158.173]:46198 "EHLO mail3.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731422AbfKHTm1 (ORCPT ); Fri, 8 Nov 2019 14:42:27 -0500 Received: from ben-dt4.candelatech.com (50-251-239-81-static.hfc.comcastbusiness.net [50.251.239.81]) by mail3.candelatech.com (Postfix) with ESMTP id C964D13C345; Fri, 8 Nov 2019 11:42:26 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com C964D13C345 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1573242146; bh=9yAS5sc0FE5J2LJfFvzsHqDYBNzwes8YiVMiKrUTMzI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NmtTIL7xjY1ZqSxdomV3NWwVPn7uqRtkEH8wxqrVdOk73HPeI2DcfkeblsmBa9tOy KOj9fDJsveyoX0pRsKtgKe8kIGZu4nUPcdeowkYmR3swdoXMXywFZW8rOjdWa+1dUB DQwaC6mmi0Sb6vEB7cpqIN+6XIJIaCkyb0EwO9gE= From: greearb@candelatech.com To: linux-wireless@vger.kernel.org Cc: johannes@sipsolutions.net, Ben Greear Subject: [PATCH 09/10] mac80211: Use warn-on-once for queue mis-configuration. Date: Fri, 8 Nov 2019 11:42:10 -0800 Message-Id: <20191108194210.23618-10-greearb@candelatech.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191108194210.23618-1-greearb@candelatech.com> References: <20191108194210.23618-1-greearb@candelatech.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Ben Greear Don't spam logs if a user manages to hit this warning. Signed-off-by: Ben Greear --- net/mac80211/util.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/mac80211/util.c b/net/mac80211/util.c index 32a7a53833c0..21c2f439fc6a 100644 --- a/net/mac80211/util.c +++ b/net/mac80211/util.c @@ -387,8 +387,11 @@ static void __ieee80211_wake_queue(struct ieee80211_hw *hw, int queue, trace_wake_queue(local, queue, reason); - if (WARN_ON(queue >= hw->queues)) + if (WARN_ON_ONCE(queue >= hw->queues)) { + pr_err("wake-queue, queue: %d > hw->queues: %d\n", + queue, hw->queues); return; + } if (!test_bit(reason, &local->queue_stop_reasons[queue])) return; -- 2.20.1