Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1976671ybc; Wed, 13 Nov 2019 07:13:05 -0800 (PST) X-Google-Smtp-Source: APXvYqxuZyEsg5Inr2YjYr6dpbmIv+6UFWseY7yD0i+XpbuL3Xbupxei8fvAckMMaAIW8mlzCISN X-Received: by 2002:a05:6402:54a:: with SMTP id i10mr3989128edx.230.1573657985601; Wed, 13 Nov 2019 07:13:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573657985; cv=none; d=google.com; s=arc-20160816; b=qoeKZoHFYA1ksiTsrQgdD+cdDHTAt4z5DRg2bEDmwdUvcHsKYC97OfNzSYT1UphHfT xvvlTrt0xa2ue6uUOq2VrSWkUba8MoU9jWWtHhdtsdZol0YxG9jVZ+YjvGu7phKUeIgi o0/cKxoBb1Jsa+RhDi1SadPY7TmbwEAnZs5xQiGT4Zn4MmDc9usy5fq5lxAm6unH4KG5 GzAklu1ETal957qgHr/IwKli2kT1zwq1hdJjbPDNhCI397vHpKOIrXyLiMSPQFVL0/Ji khcWqOhGPc1fBK0FtppCttVqr/5847KVa3o9QAI2IP2/K65A6J5OMzH1sAHV/i1tdW3Z B7lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Oet7iN8luRIwm2cG0enPN1WO0bfm28VO//v3gW2hBng=; b=g+HUeD0i1hn2FooT5C2wzQgupBtf8bE1MpsbHLbhSgMfTng4OH23q/k/Omnd6gnhR0 cUvTJKyu+6jMGc41080fPjzfCP3FI4lITs1CRCTLy1CjZ0+4o22HIVl7kPXIIuElfuB+ 5PBxC5aVqZUDD2Wn7kyCwM6IGybE/V741AuR65J0Jll5cCVn6PJF2Whq9tKhOnCgQ+u6 8H/PVFvZbEUcPJlhs4Nhm9KOGp4CosSV64/2/78FRvtOBRgu/TRDEnSebttl1xWybYnJ TJzVBCGGgf31FwHZ6yH/h2U/yAmJIT3Hwbh2hB9Gzql9A/eq9et4D/64SubvXQw59UbV YVkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GQ3XKwp2; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f2si1588126eda.339.2019.11.13.07.12.27; Wed, 13 Nov 2019 07:13:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GQ3XKwp2; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727827AbfKMPLy (ORCPT + 99 others); Wed, 13 Nov 2019 10:11:54 -0500 Received: from mail-il1-f195.google.com ([209.85.166.195]:46147 "EHLO mail-il1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727550AbfKMPLy (ORCPT ); Wed, 13 Nov 2019 10:11:54 -0500 Received: by mail-il1-f195.google.com with SMTP id q1so2072361ile.13; Wed, 13 Nov 2019 07:11:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Oet7iN8luRIwm2cG0enPN1WO0bfm28VO//v3gW2hBng=; b=GQ3XKwp2AaghEayclfUYMtj06s+kNJ3pPo2qy6o3BVVu+8If5uf39XUbSZkODmmU33 WDeAJ8hMYpRvi0cUuO/9lrc5XrrtCMRY0onKyQX+VhaWxmTI+Lz9TJj1GRzi3MxLdt04 tekoOYGqFXTHSJzb8/GuwS7hRrbPZtwG2eVfgxdjpZDVr/iJ7aDlFDftc6szgU1vzaZZ WeINd1UMXpiaoHmo3QdKl8f0o0Ow/3SUmeyIp8xIT1lRCsIZfWVSQ879lYWJ+YbUDZFI II3F90tO59YT4Nw3DJh9VTEt4ev51KZP3sH1tQ8GQslbwz1aAb4/uPva7x6OjUoSOp5j K0/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Oet7iN8luRIwm2cG0enPN1WO0bfm28VO//v3gW2hBng=; b=Em66xhI7iZmT7T/LPeWqOybGO8xX7y921lsnGQIplIt7UXDqLcwhSWXWW3A2PFTdDp NdI07XtacRO9E02E1F671F71fgkCBB4QY4MPOgrMNPttUqk0+YcSKRU7o6zHKI11lEKQ 0Y/2wERkDV137dSeG1E6PylhdAo+gx1HWHE2KkKJUlpGwa8kVZXTWvrCiuYdLE7Ohq+d Q7UDdGk88mjfNQAf0s+iSemnK3E9kF4Qh8UlO3pSIupl52kDkYgDjWoMaT5hXOFjQa5N bTP547L7khkGVIUqu1guJ+eMTjQ1qoYsX6pz5c+RV4iCrHpVCnm/MjYgkTt6Y8vjCaGW Itmg== X-Gm-Message-State: APjAAAUwwKznI1dOHVP9MtBLPCI29yxtfKU9x8i4EDTN7qdEFeRJ69gN fW+pAlV0H4DH0Bp/pSySPEkt8KcwS0s1I0a28NaNIA== X-Received: by 2002:a92:831d:: with SMTP id f29mr4564735ild.263.1573657912726; Wed, 13 Nov 2019 07:11:52 -0800 (PST) MIME-Version: 1.0 References: <20191106231650.1580-1-jeffrey.l.hugo@gmail.com> <20191112084225.casuncbo7z54vu4g@netronome.com> <87d0dws79m.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87d0dws79m.fsf@kamboji.qca.qualcomm.com> From: Jeffrey Hugo Date: Wed, 13 Nov 2019 08:11:41 -0700 Message-ID: Subject: Re: [PATCH] ath10k: Fix qmi init error handling To: Kalle Valo Cc: Simon Horman , davem@davemloft.net, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, MSM , lkml Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Nov 12, 2019 at 9:57 PM Kalle Valo wrote: > > Jeffrey Hugo writes: > > > On Tue, Nov 12, 2019 at 1:42 AM Simon Horman wrote: > >> > >> On Wed, Nov 06, 2019 at 03:16:50PM -0800, Jeffrey Hugo wrote: > >> > When ath10k_qmi_init() fails, the error handling does not free the irq > >> > resources, which causes an issue if we EPROBE_DEFER as we'll attempt to > >> > (re-)register irqs which are already registered. > >> > > >> > Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client") > >> > Signed-off-by: Jeffrey Hugo > >> > --- > >> > drivers/net/wireless/ath/ath10k/snoc.c | 2 +- > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > >> > diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c > >> > index fc15a0037f0e..f2a0b7aaad3b 100644 > >> > --- a/drivers/net/wireless/ath/ath10k/snoc.c > >> > +++ b/drivers/net/wireless/ath/ath10k/snoc.c > >> > @@ -1729,7 +1729,7 @@ static int ath10k_snoc_probe(struct platform_device *pdev) > >> > ret = ath10k_qmi_init(ar, msa_size); > >> > if (ret) { > >> > ath10k_warn(ar, "failed to register wlfw qmi client: %d\n", ret); > >> > - goto err_core_destroy; > >> > + goto err_free_irq; > >> > } > >> > >> From a casual examination of the code this seems like a step in the right > >> direction. But does this error path also need to call ath10k_hw_power_off() ? > > > > It probably should. I don't see any fatal errors from the step being > > skipped, although it might silence some regulator warnings about being > > left on. Unlikely to be observed by most folks as I was initing the > > driver pretty early to debug some things. Looks like Kalle already > > picked up this patch though, so I guess your suggestion would need to > > be a follow up. > > Actually it's only in the pending branch, which means that the patch can > be changed or a new version can be submitted: Thats an interesting flow. Ok. > > https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#patch_flow > > The easiest way to check the state of a wireless patch is from > patchwork: > > https://patchwork.kernel.org/patch/11231325/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#checking_state_of_patches_from_patchwork > > -- > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches