Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3311417ybc; Thu, 14 Nov 2019 07:14:45 -0800 (PST) X-Google-Smtp-Source: APXvYqwg+OQNVbgybuFle4fdQZHiWFXuv91P4aHIL1m2CZLwAynYnrcRurdrblzD6lqh5r0+zkv7 X-Received: by 2002:a50:90a8:: with SMTP id c37mr1810339eda.153.1573744484988; Thu, 14 Nov 2019 07:14:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573744484; cv=none; d=google.com; s=arc-20160816; b=FwKL9qHNzudno9jrhznojAWOY5+3KVeVB6HFsMdokFKMl7E4Xo3PAXclwq0N5NBPpM eqPYQMv4z6c/XCdc5xJ2DshLjhLeqHfYMOgX1//MqDOrymuCujlJblNvPkZHSC00Xkm5 I+LPmFrtBTwLzwXlmClSx82g+FgXdwDSnGxDu8x41miqKWIEVBPg3K1QpDvPzvsc2c8I M5m52NsrB+UBniCiyzvCr4PfR6LE1zBNCXcugCgmNTi2uwwK4vBqa3EgG4XZCiY5IYNQ 8M3V2F7VSacMQ2Q6XzcWEViiMFcgSsiN++vh7pKkRLgVwXilCDOVetXZ8Y9ByTBF0P+u Nisw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=vkXAV2x+72xNbnmLiSwQbs6knjBfhQ8YE06rzUnCQGo=; b=j0c8dkrEARGE6OGPBnoaPb51ya58B2j8jubcgq8z2Y+lcW7IgX/dZ4IIqUQFIe3to+ E1RoPPeSHvjokGnXUFXuaqUG/1Vwa5odaM1wwnXiwrMzhFj8+Wg7Q+/QKEFvfLe16/7P +9RvEDc5TDCAY6wgLL/vI+0At+JfA8hY6UXO/+cLYoyRG1dQ/wVlp/Oll35m5i3EbOdq PSITEBpjdYbvGLq+5rdtXIO0Jxn4st+NGPnWWXN13h3e1bIKZLajVSDDuI+lH0iRXCUT an8Xkk3xeFU4DBDAWG/e8yg7jNeGPNaLZ2QxEl12tkwwFYNFdEL3yWvqT9tCvQd37StB c+VQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=U+nFSuPi; dkim=pass header.i=@codeaurora.org header.s=default header.b=LL2wZvUe; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u22si3949959edt.172.2019.11.14.07.13.58; Thu, 14 Nov 2019 07:14:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=U+nFSuPi; dkim=pass header.i=@codeaurora.org header.s=default header.b=LL2wZvUe; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726986AbfKNPKh (ORCPT + 99 others); Thu, 14 Nov 2019 10:10:37 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:52984 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726505AbfKNPKh (ORCPT ); Thu, 14 Nov 2019 10:10:37 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A2CF760D98; Thu, 14 Nov 2019 15:10:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573744236; bh=YVUbrLMtVvtrGTOTLrUczWAJTot2SFhAPI3K9N9nIsA=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=U+nFSuPiWqmtUuMy4oVrxvGXqOiWJcJae6rAqqfyAhIMXP7ZuhJv/LIB7Md/0uD7d FO0i+KFhNyzKAjSnRvA6QN+GbcXQA71y92wfOCVFhKgUrh8cjzha+Io2QPde6FDErm lghsIkTs1yzAY5dgQDS3xHaCE2DHDp3s7JsnQwJI= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B5B3660D95; Thu, 14 Nov 2019 15:10:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573744236; bh=YVUbrLMtVvtrGTOTLrUczWAJTot2SFhAPI3K9N9nIsA=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=LL2wZvUeWu6Ut5lQnecJLsTXylQOiINfPF3uf1JHTqinwC4tYcr7w1csUpivXwDdc f6orWQKvKQu/3M/kwjJWtoEuGO49Q0GObWfrvUUaSRRoZVx1LeXBY5NyOdn2JVAKrJ 50TX028i3jGTuvZczy5BmqHh+3gYIlyluVc1CWEE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B5B3660D95 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 1/3] rtlwifi: rtl8192de: Fix missing code to retrieve RX buffer address From: Kalle Valo In-Reply-To: <20191111194046.26908-2-Larry.Finger@lwfinger.net> References: <20191111194046.26908-2-Larry.Finger@lwfinger.net> To: Larry Finger Cc: linux-wireless@vger.kernel.org, pkshih@realtek.com, Larry Finger , Stable User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20191114151036.A2CF760D98@smtp.codeaurora.org> Date: Thu, 14 Nov 2019 15:10:36 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Larry Finger wrote: > In commit 38506ecefab9 ("rtlwifi: rtl_pci: Start modification for > new drivers"), a callback to get the RX buffer address was added to > the PCI driver. Unfortunately, driver rtl8192de was not modified > appropriately and the code runs into a WARN_ONCE() call. The use > of an incorrect array is also fixed. > > Fixes: 38506ecefab9 ("rtlwifi: rtl_pci: Start modification for new drivers") > Cc: Stable # 3.18+ > Signed-off-by: Larry Finger 3 patches applied to wireless-drivers-next.git, thanks. 0e531cc575c4 rtlwifi: rtl8192de: Fix missing code to retrieve RX buffer address 3155db7613ed rtlwifi: rtl8192de: Fix missing callback that tests for hw release of buffer 330bb7117101 rtlwifi: rtl8192de: Fix missing enable interrupt flag -- https://patchwork.kernel.org/patch/11237573/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches