Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 748AE61014
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Ming Chen <ming032217@gmail.com>
Cc:     Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org,
        Ming Chen <ming.chen@watchguard.com>
Subject: Re: [PATCH v2] mac80211: Drop the packets whose source or destination mac address is empty
References: <20191114195712.101568-1-ming.chen@watchguard.com>
Date:   Fri, 15 Nov 2019 09:15:49 +0200
In-Reply-To: <20191114195712.101568-1-ming.chen@watchguard.com> (Ming Chen's
        message of "Thu, 14 Nov 2019 11:57:12 -0800")
Message-ID: <87r229boey.fsf@tynnyri.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Ming Chen <ming032217@gmail.com> writes:

> We occasionally found ath9k could receive some packets from Linux IP stack
> with empty source and destination mac address,which will result in the
> driver cannot find the station node in TX complete. And thus, the driver
> will complete this buffer but without updating the block ack window.
>
> To fix this issue, we should drop this kind of error packet before it
> goes into the driver.

The s-o-b line should be here, before the "---" line.

> ---
>
> According to review feedback, use the is_zero_ether_addr to check if the
> mac address is empty.

Very good that you added the changelog, but to make it more obvious you
could, for example, mark the changelog like this:

---

v3:

Fix s-o-b location

v2:

According to review feedback, use the is_zero_ether_addr to check if the
mac address is empty.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches