Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A1886C2BB5B
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Ming Chen <Ming.Chen@watchguard.com>
Cc:     Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>,
        Ming Chen <ming032217@gmail.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v4] mac80211: Drop the packets whose source or destination mac address is empty
References: <20191116060833.45752-1-ming.chen@watchguard.com>
        <87blt9ctd4.fsf@toke.dk>
        <DM6PR10MB2873E994ABFB1798B36CE49B9A4C0@DM6PR10MB2873.namprd10.prod.outlook.com>
Date:   Tue, 19 Nov 2019 09:41:36 +0000
In-Reply-To: <DM6PR10MB2873E994ABFB1798B36CE49B9A4C0@DM6PR10MB2873.namprd10.prod.outlook.com>
        (Ming Chen's message of "Tue, 19 Nov 2019 08:03:24 +0000")
Message-ID: <0101016e8309ed71-c2031187-906f-4d32-8ba0-e8420c76fe1e-000000@us-west-2.amazonses.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Ming Chen <Ming.Chen@watchguard.com> writes:

>> > Dropping this kind of error packet before it goes into the driver,
>> > should be the right direction.
>> 
>> So I still wonder why this happens from higher up in the stack. If there's a
>> legitimate reason, maybe dropping the packet is not the right thing? And if
>> there is *no* legitimate reason, maybe the packet should be dropped higher
>> up in the stack instead?
>> 
>> What kind of packets does this happen with?
>
> [Ming Chen] It should an ARP packet. I can see this kind of packet
> before ARP table is complete. If so, how about dropping it in the
> function of ieee80211_subif_start_xmit?

The question here is why are you seeing this but nobody else? Are you
using some special protocol, do you have some changes in the kernel
which cause this or what could explain this behaviour?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches