Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 19 Nov 2019 11:58:37 +0100
From:   Stanislaw Gruszka <sgruszka@redhat.com>
To:     Lorenzo Bianconi <lorenzo@kernel.org>
Cc:     Markus Theil <markus.theil@tu-ilmenau.de>, nbd@nbd.name,
        linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com
Subject: Re: [PATCH 3/4] mt76: speed up usb bulk copy
Message-ID: <20191119105832.GA22415@redhat.com>
References: <20191116111709.4686-1-markus.theil@tu-ilmenau.de>
 <20191116111709.4686-4-markus.theil@tu-ilmenau.de>
 <20191116114312.GC20820@localhost.localdomain>
MIME-Version: 1.0
In-Reply-To: <20191116114312.GC20820@localhost.localdomain>
User-Agent: Mutt/1.8.3 (2017-05-23)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Sat, Nov 16, 2019 at 01:43:12PM +0200, Lorenzo Bianconi wrote:
> > +=09=09memcpy(usb->data, val + i, current_batch_size);
> >  =09=09ret =3D __mt76u_vendor_request(dev, MT_VEND_MULTI_WRITE,
> >  =09=09=09=09=09     USB_DIR_OUT | USB_TYPE_VENDOR,
> > -=09=09=09=09=09     0, offset + i * 4, usb->data,
> > -=09=09=09=09=09     sizeof(u32));
> > +=09=09=09=09=09     0, offset + i, usb->data,
> > +=09=09=09=09=09     current_batch_size);
>=20
> @Stanislaw: I vaguely remember you reported some issues if the burst size=
=20
> is greater than 4B (but I can be wrong)

It didn't work as usb vendor requests which were not multiple of 4
were not transferred to the device on some usb host. But this is
properly handled by the latest version of this patch set.
=20
Stanislaw