Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 19 Nov 2019 12:19:27 +0100
From:   Stanislaw Gruszka <sgruszka@redhat.com>
To:     Markus Theil <markus.theil@tu-ilmenau.de>
Cc:     nbd@nbd.name, linux-wireless@vger.kernel.org,
        lorenzo.bianconi@redhat.com
Subject: Re: [PATCH v4 4/4] mt76: mt76x02: add channel switch support for usb
 interfaces
Message-ID: <20191119111927.GB22415@redhat.com>
References: <20191118221540.14886-1-markus.theil@tu-ilmenau.de>
 <20191118221540.14886-5-markus.theil@tu-ilmenau.de>
MIME-Version: 1.0
In-Reply-To: <20191118221540.14886-5-markus.theil@tu-ilmenau.de>
User-Agent: Mutt/1.8.3 (2017-05-23)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 18, 2019 at 11:15:40PM +0100, Markus Theil wrote:
> +static void mt76x2u_channel_switch_beacon(struct ieee80211_hw *hw,
> +=09=09=09=09=09  struct ieee80211_vif *vif,
> +=09=09=09=09=09  struct cfg80211_chan_def *chandef)
> +{
> +}
> +
>  const struct ieee80211_ops mt76x2u_ops =3D {
>  =09.tx =3D mt76x02_tx,
>  =09.start =3D mt76x2u_start,
> @@ -121,4 +127,5 @@ const struct ieee80211_ops mt76x2u_ops =3D {
>  =09.get_survey =3D mt76_get_survey,
>  =09.set_tim =3D mt76_set_tim,
>  =09.release_buffered_frames =3D mt76_release_buffered_frames,
> +=09.channel_switch_beacon =3D mt76x2u_channel_switch_beacon,

Is this needed ? Seems mac80211 check against this op being NULL
in drv_channel_switch_beacon() and it is not used otherwise.
=20
Stanislaw