Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp461672ybc; Tue, 19 Nov 2019 04:15:44 -0800 (PST) X-Google-Smtp-Source: APXvYqwjRFuVk1zo+z9XWHZuLjNpzO7k7mtiFnf/SxeaGD1+mucDFC1ifBZF7bN2q0MZ0RiF22yO X-Received: by 2002:a17:906:9248:: with SMTP id c8mr35465737ejx.47.1574165744593; Tue, 19 Nov 2019 04:15:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574165744; cv=none; d=google.com; s=arc-20160816; b=cyCw5lt9P6NFEZFcsUni9riBTju/cnyOb+1xQ7Os6rUYQ1VqcUKnAwv6YK2EojnFm0 PgYxpEFLJ3z53klZFd7M6s4X8Y8ATKQMgtaG8IynEOjb8t3jPot7UvCNTMo0TXHfDxcZ C80ywLMXiJL9tBqSgOA7uTmdNrr3kbFkIjaJh7raDyUaR1eQbQ+nqYyNU/P2GPbzEi6R 3024UohpYMgSsoP1KcxAV/aguyAVWqUGPfRT6BgIxBIl7uRkop9EgWfO2tWyRNoAMknS k6wxV85YmJmkLDMm5TBVQCy7Vm1nExSGLegSAWnPECNUghEE4YhT5LiXCAT2FUQuTZzp gZ3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=ipVxxxJysoc8QIregYcV0ylli0E42Yhd/DfdL1ALC24=; b=aRkBZsWQpnkSTzW4vzR/U69hIBDgQs/hiPU/u15hKq1BXCDLW6ph727q8Kzn7v8aBU 3Pi9aTerTf7PC3K3IKKm00l4F1KWbGFwZHzQI0DzAOEalVi2NRHE5uzYMjMjenBD4Eqi x9IxkfC6DJ5eeIPxiXLL3RKJjo2I0Y7LlkqK7DmsOt4nXMb5Ely4ZcU7W6YhIUkddx7Y 7VB6YMVrJbdZE9eaHdOJPH5jKPqDAES2CnButZK2eSrbSFdF66zGbt1FX8Q6b2STWJb0 OtZxXynb/KrpnB8ESsEZ/hgVqmRTCw7RcFILuIaqy5XyaQrbAkW6nFLbxqLsZe4vK0rn qtdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q22si13530744ejx.69.2019.11.19.04.15.07; Tue, 19 Nov 2019 04:15:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727557AbfKSMMG (ORCPT + 99 others); Tue, 19 Nov 2019 07:12:06 -0500 Received: from smail.rz.tu-ilmenau.de ([141.24.186.67]:42508 "EHLO smail.rz.tu-ilmenau.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725798AbfKSMMG (ORCPT ); Tue, 19 Nov 2019 07:12:06 -0500 Received: from [192.168.2.97] (unknown [141.24.207.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smail.rz.tu-ilmenau.de (Postfix) with ESMTPSA id 28B1558007B; Tue, 19 Nov 2019 13:12:03 +0100 (CET) Subject: Re: [PATCH v4 4/4] mt76: mt76x02: add channel switch support for usb interfaces To: Stanislaw Gruszka Cc: nbd@nbd.name, linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com References: <20191118221540.14886-1-markus.theil@tu-ilmenau.de> <20191118221540.14886-5-markus.theil@tu-ilmenau.de> <20191119111927.GB22415@redhat.com> From: Markus Theil Autocrypt: addr=markus.theil@tu-ilmenau.de; keydata= mQINBFcopAYBEADBcwd5L8+T0zgqq4kYY4nQt6CYh5sOalHdI3zNE6fWbRbzQwViIlC9Q0q/ ys+nMmQajMWHalsgcdeVSQ2GJ/06qhtogCpmL3d2/GdlvVROh33zeqwqevscKvPH5i7oiBhh dMs8/5g89q4aTYtyaausy8qQbv3Q8BCVkwFW2pEcqfxNKgWi/8nM2A3powNA9gzCR2rmoGyd nvQNkk0MCwT8JSGnUkiEYEkWF4aIr3XToavpn+OMIIIizcDzRwU5NBmC3Q07PQTn8Srr+rJQ DF65vgaoI8G7wlNLQYavL1uFX1LVMP1jVr6GMOczeURqiF/QSuHCdyT3R8P3Qknc74tGT2Ow EbxllMnk1gvSfGQq47EYIvuXFyMUWOjjtgP+NxryXVAvQBmuqWWjRjfqMSx9URhvB/ZMQLbZ LUPNW0Whl/vOQdxVbEMQOSKhKYoWKeCDe7567sEi02bMScvr6ybKBvRMs71hT1T+HFcBE/IJ g3ZX+6qRzs+XKLTFGipRbRiLYKKNR+UM/sNc/w+3BTowB9g/cQukrITvb792T4/IPBJzpEry 9eZFhFTlIqggy/fGrpZkEpEsOyOWYlRyseETvNdrdeVG7dRGPj68jKUWTVcAaAAiu8WhgnvG 4tvpaORUhjdg4DfkbE9b9lvYkeesFsE0bUAd5z2DeVbtR0QBUwARAQABtClNYXJrdXMgVGhl aWwgPG1hcmt1cy50aGVpbEB0dS1pbG1lbmF1LmRlPokCPQQTAQoAJwUCVyikBgIbAwUJB4Yf gAULCQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBt3CLaT/oEE5bzD/94Ezfl7mm57PXniW3m yIcjofJXw7YCJOprUon36W2Na2xrH3j8QH/sqkfTyCoj1LWxxDGQs+CQGkZ47cX+H1KqKKSS iGoNRV/cvoozWe7cn9bAvR3JkqLxjIi0vp68rs/f6ZI49N7zuZAsSBrXN2/2xIgH+mRoAPyw mgzaIXZL87vajXol4TlbMaC7blRs6Q4kzOP7ZjvfM/yxwUsifQltNY4wAEWKXLk67ij9akGO FG+y3sHF1HYH3w0sB+mIIN3x4BjYqXSH3XDx4xvCQXWkHmFl1RoQbJDvMjxP5/HXLR3omPjF ZpV657Grh/PgonwZ/U6sigaA11pjcPfkYNYkcGyb0OMqSKb3Ke52/bhxv4pPWrKRS7btMhj7 4zuMDk9V+De3YFXvKGllXBMAA6J8TlY71rlcOWKyBQNLLkUZ7/uAA949GTNzM0fPTRqry5qn WCR/ekzm3VyFgjWSun39L1W13bJW8aUu8k5x2KWq4YrdB0TOYZpKSAconOHVxhkEMxLwRUfZ B9kEPqlfQY5YYE6ZoZQF38Kvx3VFuAnhf+82PjMMrkQ3g07D3xJlq7xWdq1jrwG1QxmVFS64 g+oWM9IIFisvVspNrJAEgSGmYgTw+VT3PDP3Gj8sqD32mWb18bVE9I5FyagOewKdLpqcljIi Bz8WAuz+RbwX4i/mMrkCDQRXKKQGARAAzTGnHyUtTBcGHMKArcGiVnCB6knTFgU7I1gsoBrc J1bo0JRJj1lduYkdm12kC49c4dZtv1CciQIN9UEpalZsB2TXaC/xaDJ2IsZuHLOOaqSSwVg/ Bs41vMeFYmmwRRN1y6MQRCBobCC6KNuCpgtEmS/v4hurISt+MoPIppjK6E7tJQ0lgtfRHq/M HW+Wabw5Nq3OFSaLYC3nRJkoB1Vej8XGO8X6URWnZmL3xcnkIkoH13y2WTO0lJz9tF47t5U2 +xWrFMR+a6ow/QPL4Wi53IqhXDqa6OUzDAUuplZOm71VhwsEkk6u0YjzNRbgAYMBh7iye2j/ 4Lf2+YUB8+uKimpsEwW0nR85sKCQm102Zb9+1bYXPuIIP9HbVNy77X4aM9V0W48zBTqWZzh8 2i0oq8z1xN3qeuZbAXnzelKZvE1wM9cLQ3YHA629J2OGe3dkv2+untuyj6KMCEU3+vp6j7TX hKf+jy3PIrQcQmzMTs7xnkEm5LvbAtaZLrg4OGYjSpvH4bKsLA3sNGt5Xqsuqh5dsO7ccX1G nfY7Ug8UyNT5/0gZVkOileTQl0KtgwO9VBXAdrmMPHFldRn3dGNiGlCbxnsaNQDfQwTFmDu0 1TjzwC4byWLQT+C7yCTk8h9q0NwmCJ5yG7Fe7VUUpA+ZVLyMSt+tSpH8v3n+3I2AKoMAEQEA AYkCJQQYAQoADwUCVyikBgIbDAUJB4YfgAAKCRBt3CLaT/oEE7lZEACgrOxRaCQ7D5Rc4BOA N4VDIQqVch8X3pBE/k/v3UopkgmYnP4RlhegWr4wp2E6Vuyt8nwnZs3WhxQENfMjd5rV3WhG k5ib+pmLvtAht5j8jfP5+UKUTvX1a6oMi98PT8PuQ70oKM7T/KN+RpXIHoz/2Dgde1RQpwKC XWtkU9tBF87fE8FfwuqS6myOfd8zc6fOVV/fxmTXVC8qA7tB+0tOSDHB80GRYwnlumChOtOB Np8ABFWryE2e6mZZnp9Tpd1A74B45z6l445f5BixGLExAOoTJNA2k0JWx79/2Yi+pwTnQMzW QBLa48MnL3DUlVlahz1FZfGbA2U5NARS8iRdUhCaHL0Lph8HxWJwYA5w2afyCCwRD7xFo44V jsCNbqtZ6TrFARJdrbeWQl3RZ4Y+uuvN9mgvttVenAbx5d68IariYtXashucQeIMoqIloHTN sJDaupNm6+A9T3Re5yXmZsrWSxEEEGv1Bh+5DH6vauP0Ng0ebZ4c6jXfgLpPnAUWlV0rnmrJ q9141nbyLRYAhUXxiqajb+Zocp2Am4BF19rBUa1C78ooye9XShhuQvDTB6tZuiYWc24tiyqb IjR1hmG/zg8APhURAv/zUubaf4IA7v5YHVQqAbpUfb6ePlPVJBtVw2CwXFrGwnqDFh82La8D sGZPq8zmOtvOyZtafA== Message-ID: <886910ec-7ffa-1d1c-b422-bc942c8acd46@tu-ilmenau.de> Date: Tue, 19 Nov 2019 13:12:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191119111927.GB22415@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 11/19/19 12:19 PM, Stanislaw Gruszka wrote: > On Mon, Nov 18, 2019 at 11:15:40PM +0100, Markus Theil wrote: >> +static void mt76x2u_channel_switch_beacon(struct ieee80211_hw *hw, >> + struct ieee80211_vif *vif, >> + struct cfg80211_chan_def *chandef) >> +{ >> +} >> + >> const struct ieee80211_ops mt76x2u_ops = { >> .tx = mt76x02_tx, >> .start = mt76x2u_start, >> @@ -121,4 +127,5 @@ const struct ieee80211_ops mt76x2u_ops = { >> .get_survey = mt76_get_survey, >> .set_tim = mt76_set_tim, >> .release_buffered_frames = mt76_release_buffered_frames, >> + .channel_switch_beacon = mt76x2u_channel_switch_beacon, > Is this needed ? Seems mac80211 check against this op being NULL > in drv_channel_switch_beacon() and it is not used otherwise. > > Stanislaw I checked if this call is really needed and you're right, it is not needed. I'll send v5 with this fix.