Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 19 Nov 2019 15:44:11 +0100
From:   Stanislaw Gruszka <sgruszka@redhat.com>
To:     Markus Theil <markus.theil@tu-ilmenau.de>
Cc:     nbd@nbd.name, linux-wireless@vger.kernel.org,
        lorenzo.bianconi@redhat.com
Subject: Re: [PATCH v5 3/5] mt76: mt76x02: remove a copy call for usb speedup
Message-ID: <20191119144410.GA23939@redhat.com>
References: <20191119122410.12588-1-markus.theil@tu-ilmenau.de>
 <20191119122410.12588-4-markus.theil@tu-ilmenau.de>
MIME-Version: 1.0
In-Reply-To: <20191119122410.12588-4-markus.theil@tu-ilmenau.de>
User-Agent: Mutt/1.8.3 (2017-05-23)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Tue, Nov 19, 2019 at 01:24:08PM +0100, Markus Theil wrote:
> This patch removes a mt76_wr_copy call from the beacon path to hw.
> The skb which is used in this place gets therefore build with txwi
> inside its data. For mt76 usb drivers, this saves one synchronuous
> copy call over usb, which lets the beacon work complete faster.
>=20
> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
> ---
>  drivers/net/wireless/mediatek/mt76/mt76x02_beacon.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_beacon.c b/driver=
s/net/wireless/mediatek/mt76/mt76x02_beacon.c
> index 09013adae854..a9df8f2d41b8 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x02_beacon.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_beacon.c
> @@ -26,15 +26,15 @@ static int
>  mt76x02_write_beacon(struct mt76x02_dev *dev, int offset, struct sk_buff=
 *skb)
>  {
>  =09int beacon_len =3D dev->beacon_ops->slot_size;
> -=09struct mt76x02_txwi txwi;
> +=09struct mt76x02_txwi *txwi;
> =20
>  =09if (WARN_ON_ONCE(beacon_len < skb->len + sizeof(struct mt76x02_txwi))=
)
>  =09=09return -ENOSPC;
> =20
> -=09mt76x02_mac_write_txwi(dev, &txwi, skb, NULL, NULL, skb->len);
> -
> -=09mt76_wr_copy(dev, offset, &txwi, sizeof(txwi));
> -=09offset +=3D sizeof(txwi);
> +=09mt76_insert_hdr_pad(skb);
> +=09txwi =3D (struct mt76x02_txwi *)(skb->data - sizeof(*txwi));
> +=09mt76x02_mac_write_txwi(dev, txwi, skb, NULL, NULL, skb->len);
> +=09skb_push(skb, sizeof(*txwi));

This require enough skb headroom for txwi . Mac80211 reserve headroom
for us according to hw->extra_tx_headroom . Currently we ask for extra
space for txwi only for usb in mt76x02_init_device().

So this code should be put under mt76_is_usb() condition or,
what I think is less preferred, reserve extra space also for mmio.

Stanislaw