Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1525282ybc; Tue, 19 Nov 2019 23:15:41 -0800 (PST) X-Google-Smtp-Source: APXvYqzWwBK3jhGp4bH0gPf4ok9o4nYZAkRldi6eDr7ZL8DiWBr5VmNwc5lTtmGDvBK4Q+0c2UQX X-Received: by 2002:a17:906:4e94:: with SMTP id v20mr3367088eju.34.1574234140924; Tue, 19 Nov 2019 23:15:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574234140; cv=none; d=google.com; s=arc-20160816; b=sQR8IY+sqZFyRqie/QvvomP8Rix2NAe8awpCRcdtp+lt8EY7Uj4044FgaM0j/E/rV/ o+R+lkeEvK5l/ZhAS+KPoFS2YSynEhyrcuvKIZK+wOsZ8ausDJiUNlale18YGkHau0Jn rguX8U1ZDFD3BZ45Tfd9KYqWpKhQYpA1BysQ3Ouai3yhmrE4pnUsLVQbxhictjq8RnaQ 6vc9vvL/lCtBz5oOHg6sE19ZSWsc+u2Rnjm9tSEkOf6FCjXDhy3HH6Culq8gVXfUozBW aEvHhERHNmvoUF1tval29t5OEcntqDar5c/+RHgBiNYEdCvqBawXpIlL4IZ0kE6e9OZa DTrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:feedback-id:mime-version:user-agent :message-id:in-reply-to:date:references:subject:cc:to:from :dmarc-filter:dkim-signature:dkim-signature; bh=8FgVxHzCMaDEVsCQmexpmhnqOFYKVexYB3t7yk9hU8k=; b=AbQvJEaBcB30hZIiuMTBcLsWDD9+R7tjO+/wBZLZKLz8yIYlSfPl7GjCrvPfb9y45Q w2oReDJfcnrMDULVH+boxll2tGWldewVurgGVJHAWqUCRgKWmaV8PC3Zp/+YZLLikKxh lLcRwN5KsPQECcchLTrT535tjdauQxiAZr5iuV5qxat1Sckr2plw+Z0wu/ChFweL7scn 1n8rLHHLADOYzPJjyZ0dur9FS0g/x0uLfPYAenKCImH4AfLTQV58gAFIq+eY1PQkwDW4 38+mwF2xKLoYEKfeFEWG50hD52XyKxTHv5gzpaX26f6rC5pLrVuCAqzKmOZTReRWCchR Ex6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=zsmsymrwgfyinv5wlfyidntwsjeeldzt header.b=CYgYg1d2; dkim=pass header.i=@amazonses.com header.s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx header.b=HitXlYIB; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id rk9si16090232ejb.301.2019.11.19.23.15.15; Tue, 19 Nov 2019 23:15:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=zsmsymrwgfyinv5wlfyidntwsjeeldzt header.b=CYgYg1d2; dkim=pass header.i=@amazonses.com header.s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx header.b=HitXlYIB; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727791AbfKTHOk (ORCPT + 99 others); Wed, 20 Nov 2019 02:14:40 -0500 Received: from a27-21.smtp-out.us-west-2.amazonses.com ([54.240.27.21]:39784 "EHLO a27-21.smtp-out.us-west-2.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727175AbfKTHOk (ORCPT ); Wed, 20 Nov 2019 02:14:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zsmsymrwgfyinv5wlfyidntwsjeeldzt; d=codeaurora.org; t=1574234079; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:MIME-Version:Content-Type; bh=jTDnJbAD+OmeeNay72pKKr25SQyviuZ8HJ985/FTvTo=; b=CYgYg1d23p+M6KZP6LANHhnIAqafL9L7FQeUKAwPsYoFOA52/qChkuajKc8tARbE qBSaDT0g7Bc6p2UYwuBStTDd2xLLeWTad/AxEa/pXRJnntxs+iaQTEjB3D7FKO0lqcp jNAY57EiYFEGUrLxc/XuuYtEPDSZkdZ4faxrGD9Y= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx; d=amazonses.com; t=1574234079; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:MIME-Version:Content-Type:Feedback-ID; bh=jTDnJbAD+OmeeNay72pKKr25SQyviuZ8HJ985/FTvTo=; b=HitXlYIBzzUD+dI2jBlo9bjPl7kGbnb2C2bnqIjivKL3sbFJ3ddJx2xNEfZAI9vf dldpcK3WZbwnvWocKY9hieg2fggfwCd9IODFcnJ7si5mxH7Pio2mfckP5pTdOWp60VR 5L4b3d/ng6pMeoC9ZqsQyAP2sJLAeWL85qFVOh/M= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3834FC433A2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: zhengbin Cc: , , , , , , , Subject: Re: [PATCH -next] brcmfmac: remove set but not used variable 'mpnum','nsp','nmp' References: <1573888967-104078-1-git-send-email-zhengbin13@huawei.com> Date: Wed, 20 Nov 2019 07:14:39 +0000 In-Reply-To: <1573888967-104078-1-git-send-email-zhengbin13@huawei.com> (zhengbin's message of "Sat, 16 Nov 2019 15:22:47 +0800") Message-ID: <0101016e87a9bfdf-2f0de3c7-8cd5-473e-b06b-3f6dab955c23-000000@us-west-2.amazonses.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SES-Outgoing: 2019.11.20-54.240.27.21 Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org zhengbin writes: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c: In function brcmf_chip_dmp_get_regaddr: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:790:5: warning: variable mpnum set but not used [-Wunused-but-set-variable] > drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c: In function brcmf_chip_dmp_erom_scan: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:866:10: warning: variable nsp set but not used [-Wunused-but-set-variable] > drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c: In function brcmf_chip_dmp_erom_scan: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:866:5: warning: variable nmp set but not used [-Wunused-but-set-variable] > > They are introduced by commit 05491d2ccf20 ("brcm80211: > move under broadcom vendor directory"), but never used, > so remove them. > > Reported-by: Hulk Robot > Signed-off-by: zhengbin Applied, thanks. 7af496b9eb04 brcmfmac: remove set but not used variable 'mpnum','nsp','nmp' -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches