Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1553593ybc; Tue, 19 Nov 2019 23:52:03 -0800 (PST) X-Google-Smtp-Source: APXvYqz6gmR3DHLV8OiTiYqkMeCwi/oMPDE6o0EjuSnuT2TdaX6N/w7FqJEFtKW+nxR14uuYiJcW X-Received: by 2002:a17:906:1983:: with SMTP id g3mr3469361ejd.84.1574236323449; Tue, 19 Nov 2019 23:52:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574236323; cv=none; d=google.com; s=arc-20160816; b=jHtyU1qdeq/+4sJTKsf6W7udan315Qt0+9h9NB2ymKqqajd1jdWanFFJhjoHPDKQMG bW3EsM72x0idxGMiXGZScuuurrPllh+ZghQlMm1ddkldmPyZdqrNMQb8hnrzWRqmCYTM SVCwRxACU+Uj04DmgJ5If5jMo4eKEeCzii1ae29xk3fQGPTCsj7p/IHzfrAgB8FajhNV cznqZToi3uDowLac2r1OdjOV9Xn8VD9B54Jl5HAZXx+bb14NhJXpyGuq0xbMipGrBP2d l2gf32KGu9XqrBQZesvbKBMzb1dE3plp9IUQtDNaEVM31WCz84ENXkyRoNKsRSYHtvcK gT4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:feedback-id:date:message-id:user-agent:cc :to:references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=wTpYK2i0znX6lYdVOl/pvds8BolTvkSrIC1tH2RgTps=; b=As28YhLUORJC8zMAB1xqPvgY+GHGEfg0jzAOm3vqv6ZyOfgxDoThW6HEV9y+mDWTJ4 H454m/hFd8WiXRfYJ6LSr94WfBDeWHApw0gZ/lgK5yeZ2UHqr1mAZTZ80Q/Xd8Fh0FxI 4octTS71C7FuhP39WgWyqLHWQtDBvz/cij/srLIVFooZ5c/NVaudgroaZkDyekUvVqDk GmaV21LtLfyAmJLIlSSw03FnlIrxk9sYIbgaxpO74SM/OlejL+1A2IGThUh7KUJYTnJ5 D6gKL32dLuBOKfKKrKAMsAH3i9yPW6gVtZ9a3hlnW74GylcIA7JqI7zOcjMrL+yoghs3 +INw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=zsmsymrwgfyinv5wlfyidntwsjeeldzt header.b=KnL6bNv9; dkim=pass header.i=@amazonses.com header.s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx header.b=NjwOIFCd; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c8si17541756ede.323.2019.11.19.23.51.37; Tue, 19 Nov 2019 23:52:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=zsmsymrwgfyinv5wlfyidntwsjeeldzt header.b=KnL6bNv9; dkim=pass header.i=@amazonses.com header.s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx header.b=NjwOIFCd; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727508AbfKTHsd (ORCPT + 99 others); Wed, 20 Nov 2019 02:48:33 -0500 Received: from a27-186.smtp-out.us-west-2.amazonses.com ([54.240.27.186]:40898 "EHLO a27-186.smtp-out.us-west-2.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726406AbfKTHsd (ORCPT ); Wed, 20 Nov 2019 02:48:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zsmsymrwgfyinv5wlfyidntwsjeeldzt; d=codeaurora.org; t=1574236112; h=Content-Type:MIME-Version:Content-Transfer-Encoding:Subject:From:In-Reply-To:References:To:Cc:Message-Id:Date; bh=Td9UoIh2oxTOly9i8kPl6hT3h1jyV40o2qD3doA/8oc=; b=KnL6bNv9tXjTgxS0MjioLABLMiUPPMIYctVZz8mUmTdpEykLPgBXgHCUhgIKb4Te 57B4D+dk1NwMYI6jMsjU6+1+FV/CiUYWbWJknRp6pkMq3vyTJS4cp9NlOGIEIcHY7GQ t0epU1ZZItu490FOKNH3dzXrmrnBWcDtBYJNMjJo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx; d=amazonses.com; t=1574236112; h=Content-Type:MIME-Version:Content-Transfer-Encoding:Subject:From:In-Reply-To:References:To:Cc:Message-Id:Date:Feedback-ID; bh=Td9UoIh2oxTOly9i8kPl6hT3h1jyV40o2qD3doA/8oc=; b=NjwOIFCd6lPPLGX1owDgnTjiql/zakAEB0kECFxbvLbsgdJk13yHktpdyI36Aln/ jqMarJjoinl8SUQK9R87NDNx8R9UuVCEKhq4E/l0Q6Q1Jk/gM4Jlkza7GWRzAL7uO/C VWwxKpYGlhwLmh3Smv256wdA+1nohnfbwAYeFvxo= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8F9BBC43383 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH -next v2] rtl8xxxu: Remove set but not used variable 'vif', 'dev', 'len' From: Kalle Valo In-Reply-To: <1574130314-25626-1-git-send-email-zhengbin13@huawei.com> References: <1574130314-25626-1-git-send-email-zhengbin13@huawei.com> To: zhengbin Cc: , , , , User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-ID: <0101016e87c8c611-98e24f38-e5d6-45ae-b904-5a1ca8e3de9a-000000@us-west-2.amazonses.com> Date: Wed, 20 Nov 2019 07:48:32 +0000 X-SES-Outgoing: 2019.11.20-54.240.27.186 Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org zhengbin wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_c2hcmd_callback: > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5396:24: warning: variable vif set but not used [-Wunused-but-set-variable] > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_c2hcmd_callback: > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5397:17: warning: variable dev set but not used [-Wunused-but-set-variable] > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_c2hcmd_callback: > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5400:6: warning: variable len set but not used [-Wunused-but-set-variable] > > They are introduced by commit e542e66b7c2e ("rtl8xxxu: > add bluetooth co-existence support for single antenna"), but never used, > so remove them. > > Reported-by: Hulk Robot > Signed-off-by: zhengbin > Reviewed-by: Chris Chiu Patch applied to wireless-drivers-next.git, thanks. eac08515d7bd rtl8xxxu: Remove set but not used variable 'vif','dev','len' -- https://patchwork.kernel.org/patch/11250639/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches