Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 20 Nov 2019 13:42:26 +0200
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Felix Fietkau <nbd@nbd.name>
Cc:     linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com,
        ryder.lee@mediatek.com, royluo@google.com
Subject: Re: [PATCH 2/3] mt76: move coverage_class and slottime in mt76_dev
Message-ID: <20191120114226.GB21993@localhost.localdomain>
References: <cover.1573828743.git.lorenzo@kernel.org>
 <b9f6f1ff8428ba9b76244ff99b22d9949b6fabf7.1573828743.git.lorenzo@kernel.org>
 <90b792b4-98d0-accc-057d-9f1bb9cfbbb5@nbd.name>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="TakKZr9L6Hm6aLOc"
Content-Disposition: inline
In-Reply-To: <90b792b4-98d0-accc-057d-9f1bb9cfbbb5@nbd.name>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


--TakKZr9L6Hm6aLOc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> On 2019-11-15 16:05, Lorenzo Bianconi wrote:
> > Move coverage_class and slottime fields from driver specific data
> > structure to mt76_dev since they are used by all drivers
> >=20
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> Please drop this patch. I've moved a few other fields back from struct
> mt76_dev to driver specific structs, because they were in the way of
> DBDC related rework, and this one would fit the category too.
>=20
> As a general policy, I think we should only move fields to struct
> mt76_dev if they are actually used by core code as well.

ack, let's drop this patch. In the future we will need to integrate the tim=
eing
code in DBDC one since mt7615 has related regs for band0 and band1. Maybe w=
e need
to move them in mt76_phy?

Regards,
Lorenzo

>=20
> - Felix

--TakKZr9L6Hm6aLOc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXdUmngAKCRA6cBh0uS2t
rEZ9AP9nwPws6q/4tpFMEGH+jknnDNWXljLTlgQDPFpKL3c+ZAD+I7yail41q+vy
KxqjozWmCNWKDYs6YYzC0lnxgS+MbAI=
=HiLt
-----END PGP SIGNATURE-----

--TakKZr9L6Hm6aLOc--