Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1796063ybc; Wed, 20 Nov 2019 04:19:30 -0800 (PST) X-Google-Smtp-Source: APXvYqzFvL0YxWV/Q1FOZfzDND3C+zkqEbuzJcPZ6Z+j5EgyRBEIZm/StwyZnUO3g3Sd1zHU0rA6 X-Received: by 2002:a17:906:8307:: with SMTP id j7mr4832538ejx.171.1574252370767; Wed, 20 Nov 2019 04:19:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574252370; cv=none; d=google.com; s=arc-20160816; b=1FlZ5mvuYXTgOk7solodtyMzFcPBdh1Ip+YjNBnSmnz/vvk1uw36cb+w6kF5hAbVIM MGX2o/5AZGZfzKBgyUz2ncNRnMD8ap9aOl6g3FZpG59nTDAnVO/AG1Zo2MlWKx7ZqGbG 2J31R2G7OydQyBxFDnpUfwlB+9aHgTlMOMZVSFv/QneHSJMPtnppt5bWEbsrDxkQQJQK HPchMl8JAitzXJw6vbUq/0LXgxUbqHBhEOBMP0kANonbgA0jq/w8rns60AlTYNcIAg44 WOItzhkeFLx2JrnJXqCHPq6YvsMiPOLeqkjUYPySZC9usffbjyGFhVPVQhlTg+w2/c6o PlBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=s9HGliFltgRDHHUOhCW04X7lpU4VGucTS/NtbeE1OqM=; b=XE/ZmOa/3ZXsIxuN0iEdSBeJVvb7lTeV4aTiacqk0hY7L0ZyTNhDOkpSFFP3Y9d84j JW0XLr9MzX77tI/NrObO6TvYKZ5O1CXXjGCKPjKJJnWHI3K9P/w7iWgaEGllCJ64+eBW tz++nQtBlZoNoW+eOi1l0XS5U7IQqxxZcCH90OaFIFjZcTnbRR83FM5+VzanWS7Pm15Q mjYMTQt8LjK5Dob8wGFvqqy5k/TnwITJgVXbyAaBCLxPFIzcWaiLRCQhTFsUyPnVBnJ3 KjXGXy3VT4x8Rc2sNc8ujRgoRq3BxVDq1CDE/jNZzxa+kUP/mjhpPRJWHsiYOxWJPIY2 lcdw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k11si15938912ejv.152.2019.11.20.04.19.05; Wed, 20 Nov 2019 04:19:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727911AbfKTMBp (ORCPT + 99 others); Wed, 20 Nov 2019 07:01:45 -0500 Received: from smail.rz.tu-ilmenau.de ([141.24.186.67]:47378 "EHLO smail.rz.tu-ilmenau.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728728AbfKTMBp (ORCPT ); Wed, 20 Nov 2019 07:01:45 -0500 Received: from isengard.tu-ilmenau.de (unknown [141.24.207.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smail.rz.tu-ilmenau.de (Postfix) with ESMTPSA id 7AFA958007B; Wed, 20 Nov 2019 13:01:43 +0100 (CET) From: Markus Theil To: nbd@nbd.name Cc: linux-wireless@vger.kernel.org, Markus Theil Subject: [PATCH] mt76: use rcu_read_lock_bh in mt76u_rx_tasklet Date: Wed, 20 Nov 2019 13:01:38 +0100 Message-Id: <20191120120138.11427-1-markus.theil@tu-ilmenau.de> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes potential RCU issues and avoids calling ieee80211_rx_napi with softirq enabled. Signed-off-by: Markus Theil --- drivers/net/wireless/mediatek/mt76/usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wireless/mediatek/mt76/usb.c index 0ad83fb5fd38..1cfbb41f7a36 100644 --- a/drivers/net/wireless/mediatek/mt76/usb.c +++ b/drivers/net/wireless/mediatek/mt76/usb.c @@ -549,7 +549,7 @@ static void mt76u_rx_tasklet(unsigned long data) struct urb *urb; int err, count; - rcu_read_lock(); + rcu_read_lock_bh(); while (true) { urb = mt76u_get_next_rx_entry(dev); @@ -566,7 +566,7 @@ static void mt76u_rx_tasklet(unsigned long data) } mt76_rx_poll_complete(dev, MT_RXQ_MAIN, NULL); - rcu_read_unlock(); + rcu_read_unlock_bh(); } static int mt76u_submit_rx_buffers(struct mt76_dev *dev) -- 2.24.0