Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2340694ybc; Wed, 20 Nov 2019 12:36:19 -0800 (PST) X-Google-Smtp-Source: APXvYqzNyJdHnsi2Zexep4yUU3L9JKVi67MuSCcjE7YklgklbTDxKGruAux1elOLvD/eD5HmUFc8 X-Received: by 2002:a17:906:a28d:: with SMTP id i13mr7614546ejz.288.1574282179376; Wed, 20 Nov 2019 12:36:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574282179; cv=none; d=google.com; s=arc-20160816; b=MS5TGChHAN1lBghFSgCjuKCjSHEgP3mQQmvyAccU7FnU71sN7FmLYb8adLxIqilRDp aRoZR/BkDhh9bRXmfb7eK4TajlfsIx7VoTLsIrRLRqrnrQ6dt59Obqi3Gv+dPi/+y80S 0V1KNcluMGIjELnZHOZkvMwv6WQceG98ctIlWlTCRrdtZI5/AqYFrXmenq9Sqc5ZM9iA Ly0wcZXcfqq6DaXRdpkE8vwV8H5fnR4lHAR1kEAQYa71QBLTR3qNDQA5sJSkVSFrxIGM zMxOUyK8y/QrQTVtdHxprujSsfCiG2PSr21xzFvy/6q1YzCxhI+06/z98baafopsLnb4 lO/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=nh4wEMU7K4AqQKSlbaMcEDY9UZwEPeCmeQzaGubLITI=; b=c7PHNVnfE6jxRXvjd6minKJbwvDF89dFPsFwm8unIJ3n5aNe5pZSmbR2YKpAt5hnDl wyhq30S8Cfxj0bBInySDU8Zr7hYvfrJXSwawOuhtkZcs09qiGqvAs5p6sHitVSQf4saK lbG7v1bvPxnw/KE4q9THwgOBQ0j4GeYGIZxdaZhyzhdAJVuzeeC/Gwr+0kdaAq0L2SyZ OGI6uo7NzJNwyNEJq1T5VYCkHjbmodHSnsdZLTNTv6zJP9m05xI6asx4pd8RlznqBXBx m0+ol7tL+aANEZLXTdz6a7BbAIzooSLugVbi8Ow7PH2Kx9uMGSWBUyQkWY/R/zqmxcAF w9Fw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id rv12si154368ejb.372.2019.11.20.12.35.42; Wed, 20 Nov 2019 12:36:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726858AbfKTUcG (ORCPT + 99 others); Wed, 20 Nov 2019 15:32:06 -0500 Received: from smail.rz.tu-ilmenau.de ([141.24.186.67]:49636 "EHLO smail.rz.tu-ilmenau.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbfKTUcE (ORCPT ); Wed, 20 Nov 2019 15:32:04 -0500 Received: from [192.168.2.98] (unknown [141.24.207.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smail.rz.tu-ilmenau.de (Postfix) with ESMTPSA id BA57258007D; Wed, 20 Nov 2019 21:32:02 +0100 (CET) Subject: Re: [PATCH] mt76: fix fix ampdu locking To: Felix Fietkau Cc: linux-wireless@vger.kernel.org, Kalle Valo References: <20191120200531.11344-1-markus.theil@tu-ilmenau.de> <9413ca21-94c3-857b-1156-e4a949acf390@nbd.name> From: Markus Theil Autocrypt: addr=markus.theil@tu-ilmenau.de; keydata= mQINBFcopAYBEADBcwd5L8+T0zgqq4kYY4nQt6CYh5sOalHdI3zNE6fWbRbzQwViIlC9Q0q/ ys+nMmQajMWHalsgcdeVSQ2GJ/06qhtogCpmL3d2/GdlvVROh33zeqwqevscKvPH5i7oiBhh dMs8/5g89q4aTYtyaausy8qQbv3Q8BCVkwFW2pEcqfxNKgWi/8nM2A3powNA9gzCR2rmoGyd nvQNkk0MCwT8JSGnUkiEYEkWF4aIr3XToavpn+OMIIIizcDzRwU5NBmC3Q07PQTn8Srr+rJQ DF65vgaoI8G7wlNLQYavL1uFX1LVMP1jVr6GMOczeURqiF/QSuHCdyT3R8P3Qknc74tGT2Ow EbxllMnk1gvSfGQq47EYIvuXFyMUWOjjtgP+NxryXVAvQBmuqWWjRjfqMSx9URhvB/ZMQLbZ LUPNW0Whl/vOQdxVbEMQOSKhKYoWKeCDe7567sEi02bMScvr6ybKBvRMs71hT1T+HFcBE/IJ g3ZX+6qRzs+XKLTFGipRbRiLYKKNR+UM/sNc/w+3BTowB9g/cQukrITvb792T4/IPBJzpEry 9eZFhFTlIqggy/fGrpZkEpEsOyOWYlRyseETvNdrdeVG7dRGPj68jKUWTVcAaAAiu8WhgnvG 4tvpaORUhjdg4DfkbE9b9lvYkeesFsE0bUAd5z2DeVbtR0QBUwARAQABtClNYXJrdXMgVGhl aWwgPG1hcmt1cy50aGVpbEB0dS1pbG1lbmF1LmRlPokCPQQTAQoAJwUCVyikBgIbAwUJB4Yf gAULCQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBt3CLaT/oEE5bzD/94Ezfl7mm57PXniW3m yIcjofJXw7YCJOprUon36W2Na2xrH3j8QH/sqkfTyCoj1LWxxDGQs+CQGkZ47cX+H1KqKKSS iGoNRV/cvoozWe7cn9bAvR3JkqLxjIi0vp68rs/f6ZI49N7zuZAsSBrXN2/2xIgH+mRoAPyw mgzaIXZL87vajXol4TlbMaC7blRs6Q4kzOP7ZjvfM/yxwUsifQltNY4wAEWKXLk67ij9akGO FG+y3sHF1HYH3w0sB+mIIN3x4BjYqXSH3XDx4xvCQXWkHmFl1RoQbJDvMjxP5/HXLR3omPjF ZpV657Grh/PgonwZ/U6sigaA11pjcPfkYNYkcGyb0OMqSKb3Ke52/bhxv4pPWrKRS7btMhj7 4zuMDk9V+De3YFXvKGllXBMAA6J8TlY71rlcOWKyBQNLLkUZ7/uAA949GTNzM0fPTRqry5qn WCR/ekzm3VyFgjWSun39L1W13bJW8aUu8k5x2KWq4YrdB0TOYZpKSAconOHVxhkEMxLwRUfZ B9kEPqlfQY5YYE6ZoZQF38Kvx3VFuAnhf+82PjMMrkQ3g07D3xJlq7xWdq1jrwG1QxmVFS64 g+oWM9IIFisvVspNrJAEgSGmYgTw+VT3PDP3Gj8sqD32mWb18bVE9I5FyagOewKdLpqcljIi Bz8WAuz+RbwX4i/mMrkCDQRXKKQGARAAzTGnHyUtTBcGHMKArcGiVnCB6knTFgU7I1gsoBrc J1bo0JRJj1lduYkdm12kC49c4dZtv1CciQIN9UEpalZsB2TXaC/xaDJ2IsZuHLOOaqSSwVg/ Bs41vMeFYmmwRRN1y6MQRCBobCC6KNuCpgtEmS/v4hurISt+MoPIppjK6E7tJQ0lgtfRHq/M HW+Wabw5Nq3OFSaLYC3nRJkoB1Vej8XGO8X6URWnZmL3xcnkIkoH13y2WTO0lJz9tF47t5U2 +xWrFMR+a6ow/QPL4Wi53IqhXDqa6OUzDAUuplZOm71VhwsEkk6u0YjzNRbgAYMBh7iye2j/ 4Lf2+YUB8+uKimpsEwW0nR85sKCQm102Zb9+1bYXPuIIP9HbVNy77X4aM9V0W48zBTqWZzh8 2i0oq8z1xN3qeuZbAXnzelKZvE1wM9cLQ3YHA629J2OGe3dkv2+untuyj6KMCEU3+vp6j7TX hKf+jy3PIrQcQmzMTs7xnkEm5LvbAtaZLrg4OGYjSpvH4bKsLA3sNGt5Xqsuqh5dsO7ccX1G nfY7Ug8UyNT5/0gZVkOileTQl0KtgwO9VBXAdrmMPHFldRn3dGNiGlCbxnsaNQDfQwTFmDu0 1TjzwC4byWLQT+C7yCTk8h9q0NwmCJ5yG7Fe7VUUpA+ZVLyMSt+tSpH8v3n+3I2AKoMAEQEA AYkCJQQYAQoADwUCVyikBgIbDAUJB4YfgAAKCRBt3CLaT/oEE7lZEACgrOxRaCQ7D5Rc4BOA N4VDIQqVch8X3pBE/k/v3UopkgmYnP4RlhegWr4wp2E6Vuyt8nwnZs3WhxQENfMjd5rV3WhG k5ib+pmLvtAht5j8jfP5+UKUTvX1a6oMi98PT8PuQ70oKM7T/KN+RpXIHoz/2Dgde1RQpwKC XWtkU9tBF87fE8FfwuqS6myOfd8zc6fOVV/fxmTXVC8qA7tB+0tOSDHB80GRYwnlumChOtOB Np8ABFWryE2e6mZZnp9Tpd1A74B45z6l445f5BixGLExAOoTJNA2k0JWx79/2Yi+pwTnQMzW QBLa48MnL3DUlVlahz1FZfGbA2U5NARS8iRdUhCaHL0Lph8HxWJwYA5w2afyCCwRD7xFo44V jsCNbqtZ6TrFARJdrbeWQl3RZ4Y+uuvN9mgvttVenAbx5d68IariYtXashucQeIMoqIloHTN sJDaupNm6+A9T3Re5yXmZsrWSxEEEGv1Bh+5DH6vauP0Ng0ebZ4c6jXfgLpPnAUWlV0rnmrJ q9141nbyLRYAhUXxiqajb+Zocp2Am4BF19rBUa1C78ooye9XShhuQvDTB6tZuiYWc24tiyqb IjR1hmG/zg8APhURAv/zUubaf4IA7v5YHVQqAbpUfb6ePlPVJBtVw2CwXFrGwnqDFh82La8D sGZPq8zmOtvOyZtafA== Message-ID: <7fe6926e-4419-019f-3d00-7f187430f29f@tu-ilmenau.de> Date: Wed, 20 Nov 2019 21:32:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <9413ca21-94c3-857b-1156-e4a949acf390@nbd.name> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 11/20/19 9:14 PM, Felix Fietkau wrote: > On 2019-11-20 21:05, Markus Theil wrote: >> The current ampdu locking code does not unlock its mutex in the early >> return case. This patch fixes it. >> >> Signed-off-by: Markus Theil > Acked-by: Felix Fietkau > > Kalle, I think this should go on top of my pull request quickly, since > it fixes a regression in a commit from that pull request (introduced via > rebase on top of Johannes' last change of that code). > Do you want me to send another pull request with just this patch, or can > you take it directly? In the latter case, feel free to also remove one > of the two "fix" words in the subject :) Sry, ;) > > Thanks, > > - Felix