Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2918338ybc; Thu, 21 Nov 2019 00:00:43 -0800 (PST) X-Google-Smtp-Source: APXvYqw2iOYd1PbZidpEvf9HKCS1cwt8xMdnJ171iz5PSTl7NvRXPS79vPJHEzpaE0GStBOJ4H/g X-Received: by 2002:a17:906:57d7:: with SMTP id u23mr12214173ejr.130.1574323243234; Thu, 21 Nov 2019 00:00:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574323243; cv=none; d=google.com; s=arc-20160816; b=z9NZqqpxKYnlZADwNH/H79o21xDxEaucZyrfjDbobAFMFp4UA66aAYIUCt6Raj9XzU 9C/uAO4bBc47gWFoxy913DOfI5O1Wt6R6gYJvdx8J2Jmk16o8evAjCpkz/cBniE3pVMZ RBlWeOYxQD6+Cac0QWpcOgjJA/I4JPLpqaKg0KB++Nzre10qFU2VRw1Y406H0OLPlF9e io/eFsyR9fjinj6m8Vem8woF0qT0HJUDPAJG4TucFSzcklKC2W/A2hxlLYLu537Ab/uk VIaa9sbdmW/ZbdfTUj8xyzqt+Bys3tubrdZdVgCN/Kli6Et1nSmO27QK2b7mHAuOv8le 3rig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:feedback-id:mime-version:user-agent :message-id:in-reply-to:date:references:subject:cc:to:from :dmarc-filter:dkim-signature:dkim-signature; bh=RJB8Jj2K0dtEwEsCsSiwdhk3QOl6GRfGNJy/L5s2eR0=; b=BShIu9Taislga4odUYqOHi7+RxbhfX291KSUAdK2d9oVL8XQ3MSHCrOg4WSNvXr9Xm AmZYgBvWmLflFBFxJVTlUuZ8CM34tGajr7k02utuh3fPgv9wNL3zeqa4gT5aTpvxF8ys A9kKbQ++dGAR/Kgzxc7cNzNo45stTkMH3OzbBE2AgDtQiStpfFPSFUbaoC7f/3oWb+Oc 1i88VeN3dSxDwCk9o5gf3BtPGw7IUW04U2iyiiNq8vAR8N7eCDmYeGCj8UO8b+hdPZ+Y YD/RYE8YEMRC1EwF+cRVZpg8TB6O95OOPMHToE1GPT9Hh8QCWn64xviwEOVoJ3lSeEGN o5oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=zsmsymrwgfyinv5wlfyidntwsjeeldzt header.b="fNb5/nHt"; dkim=pass header.i=@amazonses.com header.s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx header.b=Q21doBDK; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id fi6si1132910ejb.430.2019.11.21.00.00.17; Thu, 21 Nov 2019 00:00:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=zsmsymrwgfyinv5wlfyidntwsjeeldzt header.b="fNb5/nHt"; dkim=pass header.i=@amazonses.com header.s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx header.b=Q21doBDK; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726265AbfKUH6c (ORCPT + 99 others); Thu, 21 Nov 2019 02:58:32 -0500 Received: from a27-185.smtp-out.us-west-2.amazonses.com ([54.240.27.185]:47136 "EHLO a27-185.smtp-out.us-west-2.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725842AbfKUH6c (ORCPT ); Thu, 21 Nov 2019 02:58:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zsmsymrwgfyinv5wlfyidntwsjeeldzt; d=codeaurora.org; t=1574323111; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:MIME-Version:Content-Type; bh=Xf2ki75QC6tyHGlOUVNCLa1WJX9C4cl/jTiNeQHTowU=; b=fNb5/nHtfDZAZ+txb43vkd+MkKMu/V9wJM0eUtA7Tuy0GBGPLYuQsWcdYczVBOvA SfxkoComBo21smurhQ6SliZW/J256CTTb8LstTXqY+ETAmLWCdBl6EljB2EFOEnuy1T CGPZpCR8v6Ij3TDewebIrverLCFHiENisAfxzOYc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx; d=amazonses.com; t=1574323111; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:MIME-Version:Content-Type:Feedback-ID; bh=Xf2ki75QC6tyHGlOUVNCLa1WJX9C4cl/jTiNeQHTowU=; b=Q21doBDKNMlWpmoRHKq3Bke77iCMA28RC2YDSUa/uNPm/YET49brn1BU2HmRVqpj dvC+iDK622l0eSWvTDSLTWTWx0BzvQguq48IaG/TL0kR38cs2oDc0TKfXtuGCXaNLg+ 2+DngY1zGxqKWsyMpj+yarmVbb5+89QLl0yqj648= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.0 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DAAF9C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Lorenzo Bianconi Cc: nbd@nbd.name, linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com, ryder.lee@mediatek.com, royluo@google.com Subject: Re: [PATCH v2 3/3] mt76: mt7615: add set_coverage class support References: <7c9088415ce08fd8b71eda9b53a4a213865886aa.1574253996.git.lorenzo@kernel.org> <0101016e8cbff2f0-f543727d-0d42-45d5-a536-64e5545d4946-000000@us-west-2.amazonses.com> <20191121074452.GA2299@localhost.localdomain> Date: Thu, 21 Nov 2019 07:58:31 +0000 In-Reply-To: <20191121074452.GA2299@localhost.localdomain> (Lorenzo Bianconi's message of "Thu, 21 Nov 2019 09:44:52 +0200") Message-ID: <0101016e8cf84614-4393ca78-b8bc-4a6f-a228-a9698d7211fd-000000@us-west-2.amazonses.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SES-Outgoing: 2019.11.21-54.240.27.185 Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Lorenzo Bianconi writes: >> Lorenzo Bianconi writes: >> >> > Add the capability to configure actimeout for mt7615 driver. Moreover >> >> acktimeout? > > Hi Kalle, > > yes, it suppposed to be acktimeout > >> >> > configure slottime according to the value provided by mac80211 >> > >> > Signed-off-by: Lorenzo Bianconi >> >> [...] >> >> > --- a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c >> > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c >> > @@ -60,6 +60,47 @@ void mt7615_mac_reset_counters(struct mt7615_dev *dev) >> > mt76_set(dev, MT_WF_RMAC_MIB_AIRTIME0, MT_WF_RMAC_MIB_RXTIME_CLR); >> > } >> > >> > +/* XXX: DBDC support */ >> > +void mt7615_mac_set_timing(struct mt7615_dev *dev) >> >> Should this be "FIXME:"? Thought don't remember what style is used in >> mt76. > > actually for DBDC we used TODO. Even better. > Should I resend? No strong feelings from me, just wanted to point out while reviewing the pathces. Up to Felix :) -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches