Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 21 Nov 2019 10:01:46 +0200
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     Lorenzo Bianconi <lorenzo@kernel.org>, nbd@nbd.name,
        linux-wireless@vger.kernel.org, ryder.lee@mediatek.com,
        royluo@google.com
Subject: Re: [PATCH v2 3/3] mt76: mt7615: add set_coverage class support
Message-ID: <20191121080146.GA2720@localhost.localdomain>
References: <cover.1574253996.git.lorenzo@kernel.org>
 <7c9088415ce08fd8b71eda9b53a4a213865886aa.1574253996.git.lorenzo@kernel.org>
 <0101016e8cbff2f0-f543727d-0d42-45d5-a536-64e5545d4946-000000@us-west-2.amazonses.com>
 <20191121074452.GA2299@localhost.localdomain>
 <0101016e8cf84124-8768f5ae-dcbe-4941-abf9-e950e6e7cf34-000000@us-west-2.amazonses.com>
MIME-Version: 1.0
In-Reply-To: <0101016e8cf84124-8768f5ae-dcbe-4941-abf9-e950e6e7cf34-000000@us-west-2.amazonses.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="PEIAKu/WMn1b1Hv9"
Content-Disposition: inline
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

--PEIAKu/WMn1b1Hv9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>=20
> >> Lorenzo Bianconi <lorenzo@kernel.org> writes:
> >>=20
> >> > Add the capability to configure actimeout for mt7615 driver. Moreove=
r
> >>=20
> >> acktimeout?
> >
> > Hi Kalle,
> >
> > yes, it suppposed to be acktimeout
> >
> >>=20
> >> > configure slottime according to the value provided by mac80211
> >> >
> >> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> >>=20
> >> [...]
> >>=20
> >> > --- a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c
> >> > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c
> >> > @@ -60,6 +60,47 @@ void mt7615_mac_reset_counters(struct mt7615_dev =
*dev)
> >> >  =09mt76_set(dev, MT_WF_RMAC_MIB_AIRTIME0, MT_WF_RMAC_MIB_RXTIME_CLR=
);
> >> >  }
> >> > =20
> >> > +/* XXX: DBDC support */
> >> > +void mt7615_mac_set_timing(struct mt7615_dev *dev)
> >>=20
> >> Should this be "FIXME:"? Thought don't remember what style is used in
> >> mt76.
> >
> > actually for DBDC we used TODO.
>=20
> Even better.
>=20
> > Should I resend?
>=20
> No strong feelings from me, just wanted to point out while reviewing the
> pathces. Up to Felix :)

ack, both ways are fine for me.

Regards,
Lorenzo

>=20
> --=20
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa=
tches
>=20

--PEIAKu/WMn1b1Hv9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXdZEZwAKCRA6cBh0uS2t
rBKGAP45zEjv+sk7kkOLrR2mXLSxsswbsC+5vq7zIXY4qwLhdAD/ZfPAxR8PDjp4
b/MqepFjeXmQTSw3zM2Zslydqz36egU=
=xzIt
-----END PGP SIGNATURE-----

--PEIAKu/WMn1b1Hv9--