Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ganapathi Bhat <gbhat@marvell.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        qize wang <wangqize888888888@gmail.com>
CC:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        amitkarwar <amitkarwar@gmail.com>,
        nishants <nishants@marvell.com>,
        huxinming820 <huxinming820@gmail.com>,
        kvalo <kvalo@codeaurora.org>, Greg KH <greg@kroah.com>,
        security <security@kernel.org>,
        linux-distros <linux-distros@vs.openwall.org>,
        Solar Designer <solar@openwall.com>
Subject: RE: [EXT] Re: [PATCH] mwifiex: Fix heap overflow in
 mmwifiex_process_tdls_action_frame()
Thread-Topic: [EXT] Re: [PATCH] mwifiex: Fix heap overflow in
 mmwifiex_process_tdls_action_frame()
Thread-Index: AQHVoSX1pZ1v8apZIkKXiiV43VGQA6eXDo3A
Date:   Fri, 22 Nov 2019 11:40:40 +0000
Message-ID: <MN2PR18MB26373BC0C0D63A7C3CE09FC4A0490@MN2PR18MB2637.namprd18.prod.outlook.com>
References: <E40E893E-D9B4-4C63-8139-1DD5E1C2CECB@gmail.com>
 <20191122111339.GH617@kadam>
In-Reply-To: <20191122111339.GH617@kadam>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c85f2eab-027e-49d7-77c4-08d76f40cd1c
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2019 11:40:40.5000
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: M9VqFcSTbKiKSsGoI+6Q9UPognC9CWhpKncrPXdmwQi5d7qWVt8wst4Os8l3+oxE3e4xeL4A7VBnJ4utzbQGzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3309
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572
 definitions=2019-11-22_02:2019-11-21,2019-11-22 signatures=0
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Hi Dan,

> > +			/* copy the ie's value into ht_capb*/
> > +			memcpy((u8 *)&sta_ptr->tdls_cap.ht_capb, pos + 2,
>                                                                  ^^^^^^^
>=20
> I don't understand why we changed "pos" to "pos + 2".  Presumably there i=
s
> a reason, but it needs to explained in the commit message.

I think, we were doing wrong in the original code. We are supposed to use '=
pos + 2' itself, instead of just 'pos'. This is because, 'pos' is pointing =
to 'ieee_types_header', followed by the actual data and the destination do =
not start with (i.e. it do not contain) 'ieee_types_header'(ex: 'sta_ptr->t=
dls_cap.ht_oper').

Also, there are few places were the destination starts with 'ieee_types_hea=
der'(ex: 'sta_ptr->tdls_cap.extcap'), which need just 'pos'.

Regards,
Ganapathi