Received: by 2002:a17:90a:88:0:0:0:0 with SMTP id a8csp140277pja; Fri, 22 Nov 2019 04:35:39 -0800 (PST) X-Google-Smtp-Source: APXvYqyEuLNK/o1o8e5F6XqlDRo4wgY2Zbv2yQfQ3uLCiD1RcV2p3m/Cv/qeiLTyEfecXqpO49ZG X-Received: by 2002:a50:becf:: with SMTP id e15mr786460edk.135.1574426139082; Fri, 22 Nov 2019 04:35:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574426139; cv=none; d=google.com; s=arc-20160816; b=qr5lNmyPBDfF5VQ76K/rkYS+C1Xlb/2Jxn8GcrA2ha3f/T3FNmQF8b/UTe4h2CuKrG snrFxF3gUvNPE/3xXO+QkuN4eKo+M2dplszgwQGzPAVpX65FDIdOtA/NErNzRHQiVpGT f+PJFUWs3O9dWSTJ36+DwfDn//AU4/3OYjhF17BpjBoriOdOKyFa/hHOxzZdu/l2WIK1 DREhVch77oRsZumSSDs8eTU4Loz9kILHewssmDsIu9ZJIP8mwYLxBvXCTl6LixnBN3aG jfNiA2WPAKQ1n6JAoN5HkxnS0xeHLCzyvGpKbJKBLfkk5CPYzn5eP2cU+WxB22dsrMi2 xXnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=0q5M5xDDsRKDLeG9aN+wMtH5yUwwtqRHS6AdD6us/N4=; b=obf2L/yVl8SgjJhkhXhwo3H2Pnan+gUNn66e9sKFmDGxdt3kmU5Hl9/GVOmxxmfsY1 TbilCVfF1N2vK1twJYyesg68nQ6Ha3jEHjy6nj53EHZCCL+tfMPJQvecWRtwykB001So 33FOEIzyBCjdlNwd6ET9m7J30eE4skcn7hVRnvaK77Cedjx+nphTbVdQ1Wxm2XYTPeKD yihxTeuGEPW+EEFJ2E9tsrivbf28Hr43LHEzZEzq0YijGnLC1rqK4Eyi/bCydCeJKFYd 6VrCH/xqLrBblX//tHC7H2Y8CdSojaa6O/wPbXOaLw7Z+HuzjkgDc3KwSLkcMFuujQFF rBxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c25si4100935ejm.224.2019.11.22.04.35.02; Fri, 22 Nov 2019 04:35:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727107AbfKVM2A (ORCPT + 99 others); Fri, 22 Nov 2019 07:28:00 -0500 Received: from s3.sipsolutions.net ([144.76.43.62]:44652 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726546AbfKVM2A (ORCPT ); Fri, 22 Nov 2019 07:28:00 -0500 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.3) (envelope-from ) id 1iY82Y-00033L-FQ; Fri, 22 Nov 2019 13:27:58 +0100 Message-ID: Subject: Re: [PATCH v11 2/4] mac80211: Import airtime calculation code from mt76 From: Johannes Berg To: Kan Yan Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, toke@redhat.com, nbd@nbd.name, yiboz@codeaurora.org, john@phrozen.org, lorenzo@kernel.org, rmanohar@codeaurora.org, kevinhayes@google.com Date: Fri, 22 Nov 2019 13:27:55 +0100 In-Reply-To: <20191119060610.76681-3-kyan@google.com> (sfid-20191119_070625_522904_ADC19544) References: <20191119060610.76681-1-kyan@google.com> <20191119060610.76681-3-kyan@google.com> (sfid-20191119_070625_522904_ADC19544) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 2019-11-18 at 22:06 -0800, Kan Yan wrote: > > +#define HE_GROUP_IDX(_streams, _gi, _bw) \ > + (IEEE80211_HE_GROUP_0 + \ > + IEEE80211_HE_MAX_STREAMS * 2 * (_bw) + \ > + IEEE80211_HE_MAX_STREAMS * (_gi) + \ > + (_streams) - 1) I'll also fix that to be " * 3" instead of 2, since there are 3 possible _gi values. johannes