Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <dea9da1dd31900306c886c308c555691552290f5.camel@sipsolutions.net>
Subject: Re: [PATCH v11 2/4] mac80211: Import airtime calculation code from
 mt76
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@redhat.com>,
        Kan Yan <kyan@google.com>
Cc:     linux-wireless@vger.kernel.org,
        make-wifi-fast@lists.bufferbloat.net, nbd@nbd.name,
        yiboz@codeaurora.org, john@phrozen.org, lorenzo@kernel.org,
        rmanohar@codeaurora.org, kevinhayes@google.com
Date:   Fri, 22 Nov 2019 14:00:01 +0100
In-Reply-To: <87tv6w3w92.fsf@toke.dk>
References: <20191119060610.76681-1-kyan@google.com>
         <20191119060610.76681-3-kyan@google.com>
         <3e7bea0cc643714ec90978a7999022544a39b118.camel@sipsolutions.net>
         <87tv6w3w92.fsf@toke.dk>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


> Well, one calculates bitrates while the other calculates airtime? ;)

:)

> But yeah, I get what you mean. I think Felix went through quite some
> pains to structure this code to avoid divisions in the fast path. I
> guess that is the main blocker for cfg80211_calculate_bitrate() to be
> used instead (assuming we do want to consolidate them eventually). Not
> sure if that can be fixed easily though?

We could also do it the other way around?

Or maybe we should keep both and use them as a sanity check for each
other :P

johannes