Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
To:     Johannes Berg <johannes@sipsolutions.net>,
        Kan Yan <kyan@google.com>
Cc:     linux-wireless@vger.kernel.org,
        make-wifi-fast@lists.bufferbloat.net, nbd@nbd.name,
        yiboz@codeaurora.org, john@phrozen.org, lorenzo@kernel.org,
        rmanohar@codeaurora.org, kevinhayes@google.com
Subject: Re: [PATCH v11 2/4] mac80211: Import airtime calculation code from mt76
In-Reply-To: <dea9da1dd31900306c886c308c555691552290f5.camel@sipsolutions.net>
References: <20191119060610.76681-1-kyan@google.com> <20191119060610.76681-3-kyan@google.com> <3e7bea0cc643714ec90978a7999022544a39b118.camel@sipsolutions.net> <87tv6w3w92.fsf@toke.dk> <dea9da1dd31900306c886c308c555691552290f5.camel@sipsolutions.net>
Date:   Fri, 22 Nov 2019 14:11:18 +0100
Message-ID: <87imnc3vk9.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Johannes Berg <johannes@sipsolutions.net> writes:

>> Well, one calculates bitrates while the other calculates airtime? ;)
>
> :)
>
>> But yeah, I get what you mean. I think Felix went through quite some
>> pains to structure this code to avoid divisions in the fast path. I
>> guess that is the main blocker for cfg80211_calculate_bitrate() to be
>> used instead (assuming we do want to consolidate them eventually). Not
>> sure if that can be fixed easily though?
>
> We could also do it the other way around?

as in bitrate =3D 1/airtime? Dunno, maybe? How important is precision to
the bitrate calculations?

> Or maybe we should keep both and use them as a sanity check for each
> other :P

Hmm, yeah, it should be possible to write a selftest to iterate through
all rates and compare the output of each calculation, shouldn't it?
Where would be a good place to put that?

-Toke