Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <994e486e8e82c01e70150eacf59dedf61b80fc65.camel@sipsolutions.net>
Subject: Re: [PATCH v11 2/4] mac80211: Import airtime calculation code from
 mt76
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@redhat.com>,
        Kan Yan <kyan@google.com>
Cc:     linux-wireless@vger.kernel.org,
        make-wifi-fast@lists.bufferbloat.net, nbd@nbd.name,
        yiboz@codeaurora.org, john@phrozen.org, lorenzo@kernel.org,
        rmanohar@codeaurora.org, kevinhayes@google.com
Date:   Fri, 22 Nov 2019 14:15:09 +0100
In-Reply-To: <87imnc3vk9.fsf@toke.dk>
References: <20191119060610.76681-1-kyan@google.com>
         <20191119060610.76681-3-kyan@google.com>
         <3e7bea0cc643714ec90978a7999022544a39b118.camel@sipsolutions.net>
         <87tv6w3w92.fsf@toke.dk>
         <dea9da1dd31900306c886c308c555691552290f5.camel@sipsolutions.net>
         <87imnc3vk9.fsf@toke.dk>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Fri, 2019-11-22 at 14:11 +0100, Toke Høiland-Jørgensen wrote:
> 
> as in bitrate = 1/airtime? Dunno, maybe? How important is precision to
> the bitrate calculations?

Not *that* important, it's just sort of advisory for userspace.

Though I think there's at least one place in mac80211 related to
radiotap that actually does use it for airtime calculation, which should
probably be changed to the new code now ...

> > Or maybe we should keep both and use them as a sanity check for each
> > other :P
> 
> Hmm, yeah, it should be possible to write a selftest to iterate through
> all rates and compare the output of each calculation, shouldn't it?
> Where would be a good place to put that?

No idea ... make a new kselftest thing for wireless?

johannes