Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2805529ybc; Mon, 25 Nov 2019 04:34:11 -0800 (PST) X-Google-Smtp-Source: APXvYqysQhpibDW11nTALK+VzrGdLTZSGcqDg8u2jgmCFX+V8uTnL17AqYQSC6AGf34W5fOWFBK7 X-Received: by 2002:a17:906:4899:: with SMTP id v25mr36434198ejq.235.1574685250920; Mon, 25 Nov 2019 04:34:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574685250; cv=none; d=google.com; s=arc-20160816; b=jQh0GHYD1zDFhxGLw5tkiih86bJ/Xxjwq4bKs+tJD4kHq4fyd7ZsKhp8zOesVq5YgT sG5DoxF89Hb9bMz5sRRdU1WtYTHBEryeBwYBAWs6pfBZhyi0LvLqSBE6H/DFXck7U6q3 ve5+ql+uue4hqAwchOUQ13tj11VKX9NkLbcB8aokwgDNjuA0egc0HkDk7XQsjHBxhP85 XZgmDLgG273xJvTqzdabmAsYjR1Tqir/LDR032bPl9ek0vmjmXN+XyJ8JrNRS6nnYuPo GQbNTXqf1Gph0aFcl2InJ4utNwUxeLTRlfnToyEFypcXdsMwTboCf7qjPcVN6OgIEogs EJyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:feedback-id:date:message-id:user-agent:cc :to:references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=WBvmNJVgsvZIrR77r8r86MuGsOoc824kT6e1uD//s7I=; b=IuaDYAwgJk3DNAdJMAmxEW+D54FAEAEe5obY43sGHrMJbMG/jzz1WAdsVwFp4aIIS7 BZ3y4oMMhG2gmhe6OW29IbuTbxwO8RSbJFG9LekyRIQWs5yHxMOal5M6wl2Puztp5ZUq IrfluTydLOx1PPdA65pKbR2TLnUsgIxZXHEzzh6cx2qvo4cLTgeQzwOsPVCBVcF8rKCT nfQlPa6KVoD1XT7pH9p3kMd8LzlBdRsdT0UAVoIotThcVz/mi1fOuG5bDOgzsDl+oLVP bYRRJbgbQ10nqTeDz7laYAn2md2dv5jOmWuilO59KrTPvLCLR9KhHcruIjrpmIVrFP0K BNYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=zsmsymrwgfyinv5wlfyidntwsjeeldzt header.b="Nbubh/YL"; dkim=pass header.i=@amazonses.com header.s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx header.b="abeOGg/T"; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gx4si4500111ejb.182.2019.11.25.04.33.46; Mon, 25 Nov 2019 04:34:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=zsmsymrwgfyinv5wlfyidntwsjeeldzt header.b="Nbubh/YL"; dkim=pass header.i=@amazonses.com header.s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx header.b="abeOGg/T"; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727430AbfKYMOJ (ORCPT + 99 others); Mon, 25 Nov 2019 07:14:09 -0500 Received: from a27-21.smtp-out.us-west-2.amazonses.com ([54.240.27.21]:53010 "EHLO a27-21.smtp-out.us-west-2.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725868AbfKYMOI (ORCPT ); Mon, 25 Nov 2019 07:14:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zsmsymrwgfyinv5wlfyidntwsjeeldzt; d=codeaurora.org; t=1574684048; h=Content-Type:MIME-Version:Content-Transfer-Encoding:Subject:From:In-Reply-To:References:To:Cc:Message-Id:Date; bh=OGZ2n8F7a9gKBAe87Xm3/4zY0uhWgsuXNCXAZXK+jtE=; b=Nbubh/YLWhd/bH8vKeZ24qTE+Dk06qTDMPfP9vDAHNDwTXCM90IVv2oer+qx6Ofg dPmV37evbR65ltzZMR9YbjF5gnYkuuR/RwpmYQWDDy4PDJjIX1FywXI7H+C9YMI0bMu v6W1jnSjFHV1w5Ax6UnY6q8X84zlosb8xiiQ/lZU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx; d=amazonses.com; t=1574684048; h=Content-Type:MIME-Version:Content-Transfer-Encoding:Subject:From:In-Reply-To:References:To:Cc:Message-Id:Date:Feedback-ID; bh=OGZ2n8F7a9gKBAe87Xm3/4zY0uhWgsuXNCXAZXK+jtE=; b=abeOGg/THu4btBCztsusmbZ5AMFxOdm+25+dAH7rLlb5lHWTpeM94CnH3JOKigx9 RZ8TThos2bDaoZDmFhD39hsf3c9QrHqU/ZJB1IQcxEh/tGk8HOdWKvw0nITSiIbTPWw D/I6wAHH9Oge/wtzNCqTwrtq0qeLNKEXTVHJr+Pc= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 147E2C447A0 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next v2] ath10k: fix RX of frames with broken FCS in monitor mode From: Kalle Valo In-Reply-To: <20191115105612.8531-1-linus.luessing@c0d3.blue> References: <20191115105612.8531-1-linus.luessing@c0d3.blue> To: =?utf-8?q?Linus_L=C3=BCssing?= Cc: ath10k@lists.infradead.org, "David S . Miller" , Ben Greear , Simon Wunderlich , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Linus_L?==?utf-8?q?=C3=BCssing?= User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-ID: <0101016ea27bbaac-2f573abe-d791-4ad8-b809-1ce481d4dbb8-000000@us-west-2.amazonses.com> Date: Mon, 25 Nov 2019 12:14:08 +0000 X-SES-Outgoing: 2019.11.25-54.240.27.21 Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Linus Lüssing wrote: > So far, frames were forwarded regardless of the FCS correctness leading > to userspace applications listening on the monitor mode interface to > receive potentially broken frames, even with the "fcsfail" flag unset. > > By default, with the "fcsfail" flag of a monitor mode interface > unset, frames with FCS errors should be dropped. With this patch, the > fcsfail flag is taken into account correctly. > > Tested-on: QCA4019 firmware-5-ct-full-community-12.bin-lede.011 > > Cc: Simon Wunderlich > Signed-off-by: Linus Lüssing > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. ea0c3e2a4702 ath10k: fix RX of frames with broken FCS in monitor mode -- https://patchwork.kernel.org/patch/11246045/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches