Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 25 Nov 2019 13:49:57 +0100
From:   Stanislaw Gruszka <sgruszka@redhat.com>
To:     Markus Theil <markus.theil@tu-ilmenau.de>
Cc:     nbd@nbd.name, linux-wireless@vger.kernel.org,
        lorenzo.bianconi@redhat.com
Subject: Re: [PATCH v8 4/6] mt76: mt76x02: remove a copy call for usb speedup
Message-ID: <20191125124956.GA28102@redhat.com>
References: <20191121180001.22451-1-markus.theil@tu-ilmenau.de>
 <20191121180001.22451-5-markus.theil@tu-ilmenau.de>
MIME-Version: 1.0
In-Reply-To: <20191121180001.22451-5-markus.theil@tu-ilmenau.de>
User-Agent: Mutt/1.11.3 (2019-02-01)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 21, 2019 at 06:59:59PM +0100, Markus Theil wrote:
> +=09if (mt76_is_usb(&dev->mt76)) {
> +=09=09struct mt76x02_txwi *txwi;
> +
> +=09=09mt76_insert_hdr_pad(skb);
> +=09=09txwi =3D (struct mt76x02_txwi *)(skb->data - sizeof(*txwi));
> +=09=09mt76x02_mac_write_txwi(dev, txwi, skb, NULL, NULL, skb->len);
> +=09=09skb_push(skb, sizeof(*txwi));
> +=09} else {
> +=09=09struct mt76x02_txwi txwi;

Here lack mt76x02_mac_write_txwi()

> =20
> -=09mt76_wr_copy(dev, offset, &txwi, sizeof(txwi));
> -=09offset +=3D sizeof(txwi);
> +=09=09mt76_wr_copy(dev, offset, &txwi, sizeof(txwi));
> +=09=09offset +=3D sizeof(txwi);

> +=09}

Stanislaw