Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 25 Nov 2019 14:00:15 +0100
From:   Stanislaw Gruszka <sgruszka@redhat.com>
To:     Markus Theil <markus.theil@tu-ilmenau.de>
Cc:     nbd@nbd.name, linux-wireless@vger.kernel.org,
        lorenzo.bianconi@redhat.com
Subject: Re: [PATCH v8 2/6] mt76: mt76x02: split beaconing
Message-ID: <20191125130014.GB28102@redhat.com>
References: <20191121180001.22451-1-markus.theil@tu-ilmenau.de>
 <20191121180001.22451-3-markus.theil@tu-ilmenau.de>
MIME-Version: 1.0
In-Reply-To: <20191121180001.22451-3-markus.theil@tu-ilmenau.de>
User-Agent: Mutt/1.11.3 (2019-02-01)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 21, 2019 at 06:59:57PM +0100, Markus Theil wrote:
> +void mt76x02_mac_set_beacon_finish(struct mt76x02_dev *dev)
> +{
> +=09mt76_wr(dev, MT_BCN_BYPASS_MASK,
> +=09=090xff00 | ~bitrev8(dev->beacon_data_mask));

Since you arrange beacon slots continues starting from 0
(i.e. 0,1,2 instead of "random" vif_idx values like 0,4,6),
I think it would make sense to keep
MT_MAC_BSSID_DW1_MBEACON_N =3D bcn_idx - 1 and set mask unchanged.

But no strong opinion here, code with bitrev8 looks fine too.

>  static void mt76x02u_beacon_enable(struct mt76x02_dev *dev, bool en)
>  {
> -=09int i;
> -
>  =09if (WARN_ON_ONCE(!dev->mt76.beacon_int))
>  =09=09return;
> =20
>  =09if (en) {
>  =09=09mt76x02u_start_pre_tbtt_timer(dev);
> -=09} else {
> -=09=09/* Timer is already stopped, only clean up
> -=09=09 * PS buffered frames if any.
> -=09=09 */

Please keep comment that timer is already disabled and
nothing else is needed.

Stanislaw