Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2906712ybc; Mon, 25 Nov 2019 06:09:21 -0800 (PST) X-Google-Smtp-Source: APXvYqzjFobWO4ZjQk/SxzfebrVkKn6suZn1o2yBQGnt5uvD9/t4Df39pSEzWXQe1O3sm4T28tSP X-Received: by 2002:adf:e506:: with SMTP id j6mr32595820wrm.19.1574690961488; Mon, 25 Nov 2019 06:09:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574690961; cv=none; d=google.com; s=arc-20160816; b=XZvHk+eNEU+49V9G9KTfU1iDbRh7U8Tzz0MKuPdSDAifrYY9Jf6VDGxYK0sljuWhdF C9Jai4anaZYGZbOnu9gZKUxoi2O+JgEXMeYV30HKJZpl26uYHpijT9imZduGYaJZGtF5 SULEwc2PSVG4C7cNiaEI0QUMmPciIseH01qE19noYfq4Ty1lggvWbLOs3CTiRDjIJBzD OvWFLfkEPBL4RI6qiLDMTjh7AoFb5UNkotSlvIXM4H99O+4/B2sMB5C6XkMEtfhUnF9u ULqp+iVhIY2BeED7/+CuDRbtJx+J81UTWGq3HIY3hTDWt8uxXEA79PszXoXMd7jCRpI1 vChw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=HN+3e7pERNtibmRteEyfFlM0aTRjC6e27bIal/r3kXQ=; b=P/mO3lZKNDWN3UBuLYgolC5IVIlvoiCiTbfmwa/2QNllV/egGloTGneQMWWS2mlaJ/ e09xusUmFkHcfgI+okNPhI2oaBNB/Y/C6byPXR5YB1BQjAOI2S5zokmDxGJgijelXd7L kiEqm0+BHs0KC2b72RVORtLTwCKWO0meB5jM1r/3YEvDHsXhX3N+M5vDle0pkJyCFb8r Dz/Db5IQO4ZF7MSLLT8gEbBZJ5xqY4w52aLfrYyT+4/6a7cxahxK4tsJe4xXOYCZq//t TVOhlxMmh1NOsjqyA1/88CCtHCF15EcpLy2lU37pEbUszhQtthcdRAH8xYaY45Hcuksg vaLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t22si4467770ejx.194.2019.11.25.06.08.53; Mon, 25 Nov 2019 06:09:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727832AbfKYOID (ORCPT + 99 others); Mon, 25 Nov 2019 09:08:03 -0500 Received: from smail.rz.tu-ilmenau.de ([141.24.186.67]:38273 "EHLO smail.rz.tu-ilmenau.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727716AbfKYOIC (ORCPT ); Mon, 25 Nov 2019 09:08:02 -0500 Received: from [192.168.2.97] (unknown [141.24.207.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smail.rz.tu-ilmenau.de (Postfix) with ESMTPSA id 4625C580068; Mon, 25 Nov 2019 15:07:59 +0100 (CET) Subject: Re: [PATCH v8 2/6] mt76: mt76x02: split beaconing To: Stanislaw Gruszka Cc: nbd@nbd.name, linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com References: <20191121180001.22451-1-markus.theil@tu-ilmenau.de> <20191121180001.22451-3-markus.theil@tu-ilmenau.de> <20191125130014.GB28102@redhat.com> From: Markus Theil Autocrypt: addr=markus.theil@tu-ilmenau.de; keydata= mQINBFcopAYBEADBcwd5L8+T0zgqq4kYY4nQt6CYh5sOalHdI3zNE6fWbRbzQwViIlC9Q0q/ ys+nMmQajMWHalsgcdeVSQ2GJ/06qhtogCpmL3d2/GdlvVROh33zeqwqevscKvPH5i7oiBhh dMs8/5g89q4aTYtyaausy8qQbv3Q8BCVkwFW2pEcqfxNKgWi/8nM2A3powNA9gzCR2rmoGyd nvQNkk0MCwT8JSGnUkiEYEkWF4aIr3XToavpn+OMIIIizcDzRwU5NBmC3Q07PQTn8Srr+rJQ DF65vgaoI8G7wlNLQYavL1uFX1LVMP1jVr6GMOczeURqiF/QSuHCdyT3R8P3Qknc74tGT2Ow EbxllMnk1gvSfGQq47EYIvuXFyMUWOjjtgP+NxryXVAvQBmuqWWjRjfqMSx9URhvB/ZMQLbZ LUPNW0Whl/vOQdxVbEMQOSKhKYoWKeCDe7567sEi02bMScvr6ybKBvRMs71hT1T+HFcBE/IJ g3ZX+6qRzs+XKLTFGipRbRiLYKKNR+UM/sNc/w+3BTowB9g/cQukrITvb792T4/IPBJzpEry 9eZFhFTlIqggy/fGrpZkEpEsOyOWYlRyseETvNdrdeVG7dRGPj68jKUWTVcAaAAiu8WhgnvG 4tvpaORUhjdg4DfkbE9b9lvYkeesFsE0bUAd5z2DeVbtR0QBUwARAQABtClNYXJrdXMgVGhl aWwgPG1hcmt1cy50aGVpbEB0dS1pbG1lbmF1LmRlPokCPQQTAQoAJwUCVyikBgIbAwUJB4Yf gAULCQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBt3CLaT/oEE5bzD/94Ezfl7mm57PXniW3m yIcjofJXw7YCJOprUon36W2Na2xrH3j8QH/sqkfTyCoj1LWxxDGQs+CQGkZ47cX+H1KqKKSS iGoNRV/cvoozWe7cn9bAvR3JkqLxjIi0vp68rs/f6ZI49N7zuZAsSBrXN2/2xIgH+mRoAPyw mgzaIXZL87vajXol4TlbMaC7blRs6Q4kzOP7ZjvfM/yxwUsifQltNY4wAEWKXLk67ij9akGO FG+y3sHF1HYH3w0sB+mIIN3x4BjYqXSH3XDx4xvCQXWkHmFl1RoQbJDvMjxP5/HXLR3omPjF ZpV657Grh/PgonwZ/U6sigaA11pjcPfkYNYkcGyb0OMqSKb3Ke52/bhxv4pPWrKRS7btMhj7 4zuMDk9V+De3YFXvKGllXBMAA6J8TlY71rlcOWKyBQNLLkUZ7/uAA949GTNzM0fPTRqry5qn WCR/ekzm3VyFgjWSun39L1W13bJW8aUu8k5x2KWq4YrdB0TOYZpKSAconOHVxhkEMxLwRUfZ B9kEPqlfQY5YYE6ZoZQF38Kvx3VFuAnhf+82PjMMrkQ3g07D3xJlq7xWdq1jrwG1QxmVFS64 g+oWM9IIFisvVspNrJAEgSGmYgTw+VT3PDP3Gj8sqD32mWb18bVE9I5FyagOewKdLpqcljIi Bz8WAuz+RbwX4i/mMrkCDQRXKKQGARAAzTGnHyUtTBcGHMKArcGiVnCB6knTFgU7I1gsoBrc J1bo0JRJj1lduYkdm12kC49c4dZtv1CciQIN9UEpalZsB2TXaC/xaDJ2IsZuHLOOaqSSwVg/ Bs41vMeFYmmwRRN1y6MQRCBobCC6KNuCpgtEmS/v4hurISt+MoPIppjK6E7tJQ0lgtfRHq/M HW+Wabw5Nq3OFSaLYC3nRJkoB1Vej8XGO8X6URWnZmL3xcnkIkoH13y2WTO0lJz9tF47t5U2 +xWrFMR+a6ow/QPL4Wi53IqhXDqa6OUzDAUuplZOm71VhwsEkk6u0YjzNRbgAYMBh7iye2j/ 4Lf2+YUB8+uKimpsEwW0nR85sKCQm102Zb9+1bYXPuIIP9HbVNy77X4aM9V0W48zBTqWZzh8 2i0oq8z1xN3qeuZbAXnzelKZvE1wM9cLQ3YHA629J2OGe3dkv2+untuyj6KMCEU3+vp6j7TX hKf+jy3PIrQcQmzMTs7xnkEm5LvbAtaZLrg4OGYjSpvH4bKsLA3sNGt5Xqsuqh5dsO7ccX1G nfY7Ug8UyNT5/0gZVkOileTQl0KtgwO9VBXAdrmMPHFldRn3dGNiGlCbxnsaNQDfQwTFmDu0 1TjzwC4byWLQT+C7yCTk8h9q0NwmCJ5yG7Fe7VUUpA+ZVLyMSt+tSpH8v3n+3I2AKoMAEQEA AYkCJQQYAQoADwUCVyikBgIbDAUJB4YfgAAKCRBt3CLaT/oEE7lZEACgrOxRaCQ7D5Rc4BOA N4VDIQqVch8X3pBE/k/v3UopkgmYnP4RlhegWr4wp2E6Vuyt8nwnZs3WhxQENfMjd5rV3WhG k5ib+pmLvtAht5j8jfP5+UKUTvX1a6oMi98PT8PuQ70oKM7T/KN+RpXIHoz/2Dgde1RQpwKC XWtkU9tBF87fE8FfwuqS6myOfd8zc6fOVV/fxmTXVC8qA7tB+0tOSDHB80GRYwnlumChOtOB Np8ABFWryE2e6mZZnp9Tpd1A74B45z6l445f5BixGLExAOoTJNA2k0JWx79/2Yi+pwTnQMzW QBLa48MnL3DUlVlahz1FZfGbA2U5NARS8iRdUhCaHL0Lph8HxWJwYA5w2afyCCwRD7xFo44V jsCNbqtZ6TrFARJdrbeWQl3RZ4Y+uuvN9mgvttVenAbx5d68IariYtXashucQeIMoqIloHTN sJDaupNm6+A9T3Re5yXmZsrWSxEEEGv1Bh+5DH6vauP0Ng0ebZ4c6jXfgLpPnAUWlV0rnmrJ q9141nbyLRYAhUXxiqajb+Zocp2Am4BF19rBUa1C78ooye9XShhuQvDTB6tZuiYWc24tiyqb IjR1hmG/zg8APhURAv/zUubaf4IA7v5YHVQqAbpUfb6ePlPVJBtVw2CwXFrGwnqDFh82La8D sGZPq8zmOtvOyZtafA== Message-ID: Date: Mon, 25 Nov 2019 15:07:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191125130014.GB28102@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 11/25/19 2:00 PM, Stanislaw Gruszka wrote: > On Thu, Nov 21, 2019 at 06:59:57PM +0100, Markus Theil wrote: >> +void mt76x02_mac_set_beacon_finish(struct mt76x02_dev *dev) >> +{ >> + mt76_wr(dev, MT_BCN_BYPASS_MASK, >> + 0xff00 | ~bitrev8(dev->beacon_data_mask)); > Since you arrange beacon slots continues starting from 0 > (i.e. 0,1,2 instead of "random" vif_idx values like 0,4,6), > I think it would make sense to keep > MT_MAC_BSSID_DW1_MBEACON_N = bcn_idx - 1 and set mask unchanged. > > But no strong opinion here, code with bitrev8 looks fine too. I'd like to keep the bitrev8 code, as it saves a copy over usb for usb devices, if MT_MAC_BSSID_DW_BEACON_N is kept constant. bitrev8 should be a rather cheap operation compared to a copy over some form of bus. >> static void mt76x02u_beacon_enable(struct mt76x02_dev *dev, bool en) >> { >> - int i; >> - >> if (WARN_ON_ONCE(!dev->mt76.beacon_int)) >> return; >> >> if (en) { >> mt76x02u_start_pre_tbtt_timer(dev); >> - } else { >> - /* Timer is already stopped, only clean up >> - * PS buffered frames if any. >> - */ > Please keep comment that timer is already disabled and > nothing else is needed. > > Stanislaw > Ok, will keep it in an updated version. Markus