Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6493312ybc; Thu, 28 Nov 2019 00:03:04 -0800 (PST) X-Google-Smtp-Source: APXvYqypdr33JK5DWXnwZCFrJQGIq/9YuTYRrECkAvDiClgAWn09Pj/F4A5U5luGad4BW6GmldvZ X-Received: by 2002:a17:906:374d:: with SMTP id e13mr11662236ejc.129.1574928184422; Thu, 28 Nov 2019 00:03:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574928184; cv=none; d=google.com; s=arc-20160816; b=P7LfMTKWO+4LfiqQw+KDb4xKWpnom/gZs7HKl+0RZe5eV68gKLaOEQm6fZo39KScv6 deA6Ob9mjeIhOPZt74x6GeQtQpJ0NR0DQz2Krbzflm9sVR4bKvJbe7NWKdrGmaBxkkWh 6TX1SQ8eqR8VuiOup2Fh0LKn0PwnN9MxE7r3Scq23oFiGYClMQuZRY649MLp0GjSnP2d sIbASDpyR/iLG68mDocMOLByEbjXrit6q5EyC2S/NmJ15c2g5/uCP0rnM81CEbLoOUVv nIL8kT577J3qDyEbiNbuT1k0wQBXyolNHryiBvcpLZaTjESoW09mmXshgbKFEq/CPmC/ iXEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:feedback-id:date:message-id:user-agent:cc :to:references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=yVx/a6PSk/oDnJHjRT+WH+lcbTskCvkvzaOe6xb75RU=; b=gZn5Ws89gGkg50+SPNMtaLtXAWeOKBBkviA/KogaJ3MohdupIlbpoh37f/A8/zcqyQ yYZRBmsC0Lmi4FKJ5baNY/4NeS+y314H2Z8cDhdxTzxCUktWB/y3xKB2hq2x7FhlKUkT pOXKaUC5P4/m9OgONhh31Gwc+D5uNaa4T5t7XWFf03JASRskVefR1FtTcsaAuZNX3P1d shGI7AFV+RT+Jva5flZVNdbaiOSQIZEWiF3JOXXVHGHSmBjSpc0vApWDZGVSQN5iOoO3 1/Hn44XXqxCYKb58lDRJcTedBzl5Mewu2QMXET5pxnoNjmQWxZwJz4bUjBwmC7/AqmFU aryw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=zsmsymrwgfyinv5wlfyidntwsjeeldzt header.b=mioruUJg; dkim=pass header.i=@amazonses.com header.s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx header.b=dvNajh+Z; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h11si14097031ede.45.2019.11.28.00.02.19; Thu, 28 Nov 2019 00:03:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=zsmsymrwgfyinv5wlfyidntwsjeeldzt header.b=mioruUJg; dkim=pass header.i=@amazonses.com header.s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx header.b=dvNajh+Z; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727156AbfK1IAr (ORCPT + 99 others); Thu, 28 Nov 2019 03:00:47 -0500 Received: from a27-187.smtp-out.us-west-2.amazonses.com ([54.240.27.187]:39194 "EHLO a27-187.smtp-out.us-west-2.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726963AbfK1IAr (ORCPT ); Thu, 28 Nov 2019 03:00:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zsmsymrwgfyinv5wlfyidntwsjeeldzt; d=codeaurora.org; t=1574928046; h=Content-Type:MIME-Version:Content-Transfer-Encoding:Subject:From:In-Reply-To:References:To:Cc:Message-Id:Date; bh=R170+eucBgwGB7vYzNNsgn9IJoatW8gOmldds1sVyjg=; b=mioruUJg94nm4wS2aZ0BcmWzr2bh2c8PFBTj5gNKGof7cZU2tA3/B5X1Lfn2/QNh G2ok4qqjeK5mB3Rta9yytqNfGzlmWQYJstcWCYT2b8q7nToMy/BNC9834A/nWIoxx4+ +MiTZOkPWUiaO4foQGaW+2jahpkUfhp3/wg334qA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx; d=amazonses.com; t=1574928046; h=Content-Type:MIME-Version:Content-Transfer-Encoding:Subject:From:In-Reply-To:References:To:Cc:Message-Id:Date:Feedback-ID; bh=R170+eucBgwGB7vYzNNsgn9IJoatW8gOmldds1sVyjg=; b=dvNajh+Z41y4VWNFi+tKP1MB6sHOWP9ApvyEW6B+QdJTv92Ydx2tjJNhCTehrVBY 3VgLEN4Xbf64Iah+iafFUKx7F0ja6Rgw4gejBf7nf0GLmM18vK1Q8CsBkSGrQyR5jg9 aG/X5pfJWYbVB4B4kloPCx1NzihNpX0Ry6nS1yJs= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9C5FEC43383 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] libertas: Fix two buffer overflows at parsing bss descriptor From: Kalle Valo In-Reply-To: <20191122052917.11309-1-huangwenabc@gmail.com> References: <20191122052917.11309-1-huangwenabc@gmail.com> To: huangwenabc@gmail.com Cc: linux-wireless@vger.kernel.org, linux-distros@vs.openwall.org, security@kernel.org, libertas-dev@lists.infradead.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-ID: <0101016eb106d929-1a3d21ee-77b1-4cc4-a3af-a2adeaafe048-000000@us-west-2.amazonses.com> Date: Thu, 28 Nov 2019 08:00:46 +0000 X-SES-Outgoing: 2019.11.28-54.240.27.187 Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org huangwenabc@gmail.com wrote: > From: Wen Huang > > add_ie_rates() copys rates without checking the length > in bss descriptor from remote AP.when victim connects to > remote attacker, this may trigger buffer overflow. > lbs_ibss_join_existing() copys rates without checking the length > in bss descriptor from remote IBSS node.when victim connects to > remote attacker, this may trigger buffer overflow. > Fix them by putting the length check before performing copy. > > This fix addresses CVE-2019-14896 and CVE-2019-14897. > > Signed-off-by: Wen Huang Please fix the warning reported by kbuild bot. Patch set to Changes Requested. -- https://patchwork.kernel.org/patch/11257187/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches