Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6499288ybc; Thu, 28 Nov 2019 00:07:24 -0800 (PST) X-Google-Smtp-Source: APXvYqxZzb54ayS5NIHHrSz1CyXX38YBBk5qO4qAU6mmFSEBee+rLPqcKDe5/R6qRACicgdees8F X-Received: by 2002:a05:6402:13cd:: with SMTP id a13mr36855042edx.57.1574928444755; Thu, 28 Nov 2019 00:07:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574928444; cv=none; d=google.com; s=arc-20160816; b=pZj48XibJm2zGONkq7RhBMGc3oMQ+IPflAF4pLvdgW0d37dfjVcuxileQh0baEcIim bkwCAHfp40rzyVCUyp5yeZt+Yh77uaaUzyGUK49CXq6zNtjVIxzuvDDlGEMAfE0GJ6pX iUzP/4zxGKVNEAh6z/NSk0GwEksxF/CI6mz8U8y1IhQs7946/7XY/ePRbd99R/ozd43+ fbrqhrRoRpVQvvZWOlS6j4caRnrtrjeJjFOi9UIO/IR94hxgQw6vDv3E6h0npseLf6Re kOGEa4A2TrWGk7uVJJDiuuhizlJA+Z0R4y8TXo5QW7vZPnnGpiQl9TUggBU00GzritKn gw7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:feedback-id:date:message-id:user-agent:cc :to:references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=W/d/lcTQZZYiq/lBhwv/PusgtoeZIhS7g5jwF8EnmUU=; b=Zdyu1bu0WSBBWhnf3jMF+abul3WvrPWt9ptYHNqciW0jsISoSE0ra0dgzbLVpBl46K kKeSccUGyN8clcyLzKUGefu0UgyTB2EllwQqQMQWA3uWlYuJrzzJ43VeiSa7c3tcgFi4 nW45V8M/OMIpovyMQ/R6+aYNHi50Ynln62/4cVKVkaUyg4gDtlzGXVtDBTJ5PkXENVXa Dq555jXB9ZvJGS04IqVYym4n8VOc9QwJybCWn4IrEgaHHtJZHEaWdzwpYwMAzSRemoP9 ado4bb0oBSsboHX65pZqHksUCpXgdAXq+4tucwQbZVB1jBqJip8jiP/bMUbnjYkH425R FfoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=zsmsymrwgfyinv5wlfyidntwsjeeldzt header.b=c8ZnJTk9; dkim=pass header.i=@amazonses.com header.s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx header.b=YeDrXnG4; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y4si5133525eds.288.2019.11.28.00.06.58; Thu, 28 Nov 2019 00:07:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=zsmsymrwgfyinv5wlfyidntwsjeeldzt header.b=c8ZnJTk9; dkim=pass header.i=@amazonses.com header.s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx header.b=YeDrXnG4; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726684AbfK1IFL (ORCPT + 99 others); Thu, 28 Nov 2019 03:05:11 -0500 Received: from a27-187.smtp-out.us-west-2.amazonses.com ([54.240.27.187]:40704 "EHLO a27-187.smtp-out.us-west-2.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726301AbfK1IFK (ORCPT ); Thu, 28 Nov 2019 03:05:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zsmsymrwgfyinv5wlfyidntwsjeeldzt; d=codeaurora.org; t=1574928310; h=Content-Type:MIME-Version:Content-Transfer-Encoding:Subject:From:In-Reply-To:References:To:Cc:Message-Id:Date; bh=GxwUw6Gq7BL40TcTKR/Z4WDw9MS/45w0vLNGTTYaQzY=; b=c8ZnJTk9ljbbhAnj4IAq+UwOBbuinmzV2aLwu9bb31AhNsn9rAD6x5sTGz4gPANX M84Be2lCtZQQgnccF7ZTqwSYSir9FiPn6ZrYCmMV8kSJQLxB2UC8wk1Mp6/GjSQn3I8 KCVT/AXkUZ0X7jshnqUGkzJ3peJCJ8DPb2ICRFt8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx; d=amazonses.com; t=1574928310; h=Content-Type:MIME-Version:Content-Transfer-Encoding:Subject:From:In-Reply-To:References:To:Cc:Message-Id:Date:Feedback-ID; bh=GxwUw6Gq7BL40TcTKR/Z4WDw9MS/45w0vLNGTTYaQzY=; b=YeDrXnG45KJhWRjTEy95dLwFGEOlP26Mm/L9fBIG05WfIpjCT5d/Uhx/V1b7gj3O YKcNZFzLcXiX1AMd1zw/UaqmEvmPOjxp0jRhNhrib3HTB8nmfA8tWvM2ycqSa17BxiR Ehjxnpy7cMCnDQCGqmB/K17CQ1a/o+033EIP/b4M= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 35FD8C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] mwifiex: Fix heap overflow in mmwifiex_process_tdls_action_frame() From: Kalle Valo In-Reply-To: References: To: qize wang Cc: linux-wireless@vger.kernel.org, amitkarwar , nishants , gbhat , huxinming820 , Greg KH , "dan.carpenter" , Solar Designer User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-ID: <0101016eb10adf1b-06d87453-6fe9-414b-9114-23b8e50c5c3e-000000@us-west-2.amazonses.com> Date: Thu, 28 Nov 2019 08:05:10 +0000 X-SES-Outgoing: 2019.11.28-54.240.27.187 Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org qize wang wrote: > mwifiex_process_tdls_action_frame() without checking > the incoming tdls infomation element's vality before use it, > this may cause multi heap buffer overflows. > > Fix them by putting vality check before use it. > > Signed-off-by: qize wang Please fix the commit log as explained by Dan. Patch set to Changes Requested. -- https://patchwork.kernel.org/patch/11257535/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches