Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp6718808ybc; Thu, 28 Nov 2019 04:20:24 -0800 (PST) X-Google-Smtp-Source: APXvYqwVWE186voad3SbqMrjU96XzkjALXQF4fIdOLeTEn5N//1Bs89AN4k/BpX8v5GN1/TM450G X-Received: by 2002:a17:906:9417:: with SMTP id q23mr55195497ejx.37.1574943624551; Thu, 28 Nov 2019 04:20:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574943624; cv=none; d=google.com; s=arc-20160816; b=dPLf6L2JQpTir482JFZHLJ1vk4hyb1WMDqOM0bLA33VsnWks6uuQ+8fz3vALnqXCqt 2I9JTQia0B094QfKV4KWYGjSeWEoVOjhl9lbzX2UoLWCKWZk2KrLak91PGLd2y97XjoP 65kAKW+BMsGxRibIAZHJFSqgO7AyaD3sgkvYT57XEsgHiR2QnHyN6SltevH2hvWI72AW kD6gFDC5hKr6HBv7RpD1GiMknoJILJ1LDmPh1XKeAsX1aAuoAeiXc1sv+XtEsmb3SoDt gKpcixOOieRK2D5MHUeuCDkuDZa9do2PwlSE3N8MSaxzUxg10Mx2CD5V2MFDDPANPGad a2jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:authenticated-by; bh=GJsoGENYjjTuqlbD326arDjQmmETIVX7MG5zosFbJmg=; b=ueDcTTUbHplUMKxfOtiOF1EW3cZxu1FWHtvOvbpBB2cd3gnxfai3lz41XdBPh9dD5z Z5SvGsDjpYGjBB5yLACHg4i1cYFiVux8EN3hDCQWHgRcYvpMQ+Cal/uwTienJdfJidSZ PQTM6ve/7nbT3z0o0r9xTSHlVc4ToOF/GQOJjf8/ybcQw4f2o7FaIpbrS/K7kfHzyYd4 TdbVd31ZfXmjSzvJBbxtL8T+cyZMKn0h4kAn64y/P52U0G5HrujoXx3GpraQre8DLTsT gg1FWnyBj7+4F6J67i5e+Kur3a5HSvcKZVvtilRQPx7Lx0rgJ5HKDmdlW0GglkuQI9uo Kwvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r10si2103974eja.134.2019.11.28.04.19.48; Thu, 28 Nov 2019 04:20:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726773AbfK1MTV (ORCPT + 99 others); Thu, 28 Nov 2019 07:19:21 -0500 Received: from rtits2.realtek.com ([211.75.126.72]:59537 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726383AbfK1MTV (ORCPT ); Thu, 28 Nov 2019 07:19:21 -0500 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.62 with qID xASCJDmo004448, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (RTITCASV01.realtek.com.tw[172.21.6.18]) by rtits2.realtek.com.tw (8.15.2/2.57/5.78) with ESMTPS id xASCJDmo004448 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 28 Nov 2019 20:19:13 +0800 Received: from localhost.localdomain (172.21.68.126) by RTITCASV01.realtek.com.tw (172.21.6.18) with Microsoft SMTP Server id 14.3.468.0; Thu, 28 Nov 2019 20:19:13 +0800 From: To: CC: , Subject: [PATCH 2/6] rtw88: pci: reset dma when reset pci trx ring Date: Thu, 28 Nov 2019 20:19:03 +0800 Message-ID: <20191128121907.6178-3-yhchuang@realtek.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191128121907.6178-1-yhchuang@realtek.com> References: <20191128121907.6178-1-yhchuang@realtek.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.21.68.126] Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Chin-Yen Lee When pci trx ring is reset, hw dma setting should be reset together. Otherswise, the rx_tag of rx flow is not synchronous to hw. Signed-off-by: Chin-Yen Lee Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/pci.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c index 068f1bec88e6..78971cefb948 100644 --- a/drivers/net/wireless/realtek/rtw88/pci.c +++ b/drivers/net/wireless/realtek/rtw88/pci.c @@ -486,13 +486,6 @@ static void rtw_pci_disable_interrupt(struct rtw_dev *rtwdev, rtwpci->irq_enabled = false; } -static int rtw_pci_setup(struct rtw_dev *rtwdev) -{ - rtw_pci_reset_trx_ring(rtwdev); - - return 0; -} - static void rtw_pci_dma_reset(struct rtw_dev *rtwdev, struct rtw_pci *rtwpci) { /* reset dma and rx tag */ @@ -501,6 +494,16 @@ static void rtw_pci_dma_reset(struct rtw_dev *rtwdev, struct rtw_pci *rtwpci) rtwpci->rx_tag = 0; } +static int rtw_pci_setup(struct rtw_dev *rtwdev) +{ + struct rtw_pci *rtwpci = (struct rtw_pci *)rtwdev->priv; + + rtw_pci_reset_trx_ring(rtwdev); + rtw_pci_dma_reset(rtwdev, rtwpci); + + return 0; +} + static void rtw_pci_dma_release(struct rtw_dev *rtwdev, struct rtw_pci *rtwpci) { struct rtw_pci_tx_ring *tx_ring; -- 2.17.1