Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 29 Nov 2019 14:06:30 +0100
From:   Stanislaw Gruszka <sgruszka@redhat.com>
To:     Lorenzo Bianconi <lorenzo@kernel.org>
Cc:     linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
        Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Roy Luo <royluo@google.com>,
        Markus Theil <markus.theil@tu-ilmenau.de>
Subject: Re: [PATCH 1/3] mt76: usb: use max packet length for m76u_copy
Message-ID: <20191129130630.GA2497@redhat.com>
References: <1575030748-2218-1-git-send-email-sgruszka@redhat.com>
 <1575030748-2218-2-git-send-email-sgruszka@redhat.com>
 <20191129124744.GE32696@localhost.localdomain>
MIME-Version: 1.0
In-Reply-To: <20191129124744.GE32696@localhost.localdomain>
User-Agent: Mutt/1.5.21 (2010-09-15)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 29, 2019 at 02:47:44PM +0200, Lorenzo Bianconi wrote:
> > +=09usb->data_len =3D usb_maxpacket(udev, usb_sndctrlpipe(udev, 0), 1);
> > +=09if (usb->data_len < 32)
> > +=09=09usb->data_len =3D 32;
>=20
> Hi Stanislaw,
>=20
> =09usb->data_len =3D max_t(u16, 32,
> =09=09=09      usb_maxpacket(udev, usb_sndctrlpipe(udev, 0), 1));
>=20

Why this is better ?

> Moreover are you sure using ctrl endpoint 0 is fine for all devices?

usb_sndctrlpipe(udev, 0) is used in __mt76u_vendor_request() for all=20
out requests i.e. on all cases were usb->data is used.

Stanislaw=20