Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 29 Nov 2019 15:11:25 +0200
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Stanislaw Gruszka <sgruszka@redhat.com>
Cc:     linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
        Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Roy Luo <royluo@google.com>,
        Markus Theil <markus.theil@tu-ilmenau.de>
Subject: Re: [PATCH 1/3] mt76: usb: use max packet length for m76u_copy
Message-ID: <20191129131125.GF32696@localhost.localdomain>
References: <1575030748-2218-1-git-send-email-sgruszka@redhat.com>
 <1575030748-2218-2-git-send-email-sgruszka@redhat.com>
 <20191129124744.GE32696@localhost.localdomain>
 <20191129130630.GA2497@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="vA66WO2vHvL/CRSR"
Content-Disposition: inline
In-Reply-To: <20191129130630.GA2497@redhat.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


--vA66WO2vHvL/CRSR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> On Fri, Nov 29, 2019 at 02:47:44PM +0200, Lorenzo Bianconi wrote:
> > > +	usb->data_len =3D usb_maxpacket(udev, usb_sndctrlpipe(udev, 0), 1);
> > > +	if (usb->data_len < 32)
> > > +		usb->data_len =3D 32;
> >=20
> > Hi Stanislaw,
> >=20
> > 	usb->data_len =3D max_t(u16, 32,
> > 			      usb_maxpacket(udev, usb_sndctrlpipe(udev, 0), 1));
> >=20
>=20
> Why this is better ?

More readable for my point of view

>=20
> > Moreover are you sure using ctrl endpoint 0 is fine for all devices?
>=20
> usb_sndctrlpipe(udev, 0) is used in __mt76u_vendor_request() for all=20
> out requests i.e. on all cases were usb->data is used.

ops, right :) Thx for for pointing this out.

Regards,
Lorenzo

>=20
> Stanislaw=20
>=20

--vA66WO2vHvL/CRSR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXeEY+gAKCRA6cBh0uS2t
rBgsAP9r/zVUzE7kuaXvSCHfrbrkKRRz0waUGAz4w6RnyNv83gD9FIwG4H+t0ycI
Euef/np4w/ZzEOtkDHxG2uSOlrlg6wc=
=8Dkr
-----END PGP SIGNATURE-----

--vA66WO2vHvL/CRSR--