Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0AC81C447AE
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Anders Kaseorg <andersk@mit.edu>
Cc:     Johannes Berg <johannes.berg@intel.com>,
        Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
        Luca Coelho <luciano.coelho@intel.com>,
        Intel Linux Wireless <linuxwifi@intel.com>,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH v1.2] Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ detection"
References: <alpine.DEB.2.21.999.1912010127330.108936@department-of-alchemy.mit.edu>
        <alpine.DEB.2.21.999.1912021653360.21300@department-of-alchemy.mit.edu>
        <alpine.DEB.2.21.999.1912021706060.21300@department-of-alchemy.mit.edu>
Date:   Tue, 3 Dec 2019 07:39:28 +0000
In-Reply-To: <alpine.DEB.2.21.999.1912021706060.21300@department-of-alchemy.mit.edu>
        (Anders Kaseorg's message of "Mon, 2 Dec 2019 17:09:20 -0500 (EST)")
Message-ID: <0101016ecab326d1-88123857-cf37-47ab-b452-13658625364c-000000@us-west-2.amazonses.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Anders Kaseorg <andersk@mit.edu> writes:

> This reverts commit 968dcfb4905245dc64d65312c0d17692fa087b99.
>
> Both that commit and commit 809805a820c6445f7a701ded24fdc6bbc841d1e4
> attempted to fix the same bug (dead assignments to the local variable
> cfg), but they did so in incompatible ways. When they were both merged,
> independently of each other, the combination actually caused the bug to
> reappear, leading to a firmware crash on boot for some cards.
>
> https://bugzilla.kernel.org/show_bug.cgi?id=205719
>
> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
> ---
> [Nope it was more than just format=flowed damage. This one should be
> better for real.]

This is nitpicking but as a general comment I would prefer to use simple
version numbering v2, v3 and so on. Trying to sort v1.2 in a script is
awful. So calling this version v3 is very much preferred, it's not like
we are running out of numbers :)

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches