Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp755808ybl; Wed, 4 Dec 2019 10:19:06 -0800 (PST) X-Google-Smtp-Source: APXvYqwdcwOZRlP42J2Ix8n1WjSKBKx6AzHzKH52DLimapXWz7sRve6pyuLZJ/5ndsvcVkkwBBip X-Received: by 2002:a05:6830:10a:: with SMTP id i10mr3386523otp.365.1575483546455; Wed, 04 Dec 2019 10:19:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575483546; cv=none; d=google.com; s=arc-20160816; b=l74ip+65LiGqKrGUXAlU7WgY63rYo7URkrUWhfk4f8C+lsW4le8qOXl5ziFh5iX3Gb MsVwNhmqQar7Mfgb9+fR5L7Cxa2n+IHT1pJDw6Gzeee1b+HbQ0WrSU8RdGzFgZQQd/ND 93Y4ng2/R+68bqnrUEoa5/u5Q2lfnrgzhe0kc920z9kzfdEj+ndCsrICQgKugMbFHyGG n+eNcruqOo6RqtSGQI2WY5CCsCOaoFOZMd8sK1WAfDfOChRKUYPsNBJp5INgNEThTzEj c2RUvy32Wy3oLYmenHSm1RA80UiVswT9380I+Cqbk5h1dJ/+0s0jZjhU7vukd+mKLicb phIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=AdC7y5Y398mLbr30ogjibNKI+fxF5YyzcSKAsONjyHo=; b=lj3nLDOySNjrCumMCPx8IzO2EKM3isUqoBi5Gd/lm0iC6ftBtHgsnMjnPL3egD+3Vd CVJ7d9RmAQt7GluOJzolAGHrRbDk5K9tYvaV6l3ZrBtpB0GGuN7B3/jat0jNOwIIUucj dLi8+i28v5/9UVrS6AVEhgtPeOd7i3PB+78mtaa4yNkrgiSxPvrOoSBinS7EaEPZzcVS znxTOuhO4z6FZbkujQZIk+SnSk9cr4P2+M0MP6CmdwUcWX/T3FKxR73y/M3BprO/uvM9 05RdYhZiKLZxW0wR9Kv6DBEqcsNLvESjVbGGWNMB+JKLzlEL7jqVmGHmpxExJW7P5uBj RYwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o15si3447404otk.221.2019.12.04.10.18.45; Wed, 04 Dec 2019 10:19:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731817AbfLDSSB (ORCPT + 99 others); Wed, 4 Dec 2019 13:18:01 -0500 Received: from nbd.name ([46.4.11.11]:40922 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731563AbfLDSR5 (ORCPT ); Wed, 4 Dec 2019 13:17:57 -0500 Received: from p5dcfb666.dip0.t-ipconnect.de ([93.207.182.102] helo=bertha.datto.lan) by ds12 with esmtpa (Exim 4.89) (envelope-from ) id 1icZDl-0005Od-Ob; Wed, 04 Dec 2019 19:17:53 +0100 From: John Crispin To: Kalle Valo Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, John Crispin Subject: [PATCH V2 3/9] ath11k: drop memset when setting up a tx cmd desc Date: Wed, 4 Dec 2019 19:17:39 +0100 Message-Id: <20191204181745.27297-4-john@phrozen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191204181745.27297-1-john@phrozen.org> References: <20191204181745.27297-1-john@phrozen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org There is no point in zero'ing out the structure if we set all values in the following line. Signed-off-by: John Crispin --- drivers/net/wireless/ath/ath11k/dp_tx.c | 2 -- drivers/net/wireless/ath/ath11k/hal_tx.c | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/dp_tx.c b/drivers/net/wireless/ath/ath11k/dp_tx.c index a8b9557c2346..28ebc414533e 100644 --- a/drivers/net/wireless/ath/ath11k/dp_tx.c +++ b/drivers/net/wireless/ath/ath11k/dp_tx.c @@ -167,8 +167,6 @@ int ath11k_dp_tx(struct ath11k *ar, struct ath11k_vif *arvif, skb_cb->vif = arvif->vif; skb_cb->ar = ar; - memset(cached_desc, 0, HAL_TCL_DESC_LEN); - ath11k_hal_tx_cmd_desc_setup(ab, cached_desc, &ti); hal_ring_id = tx_ring->tcl_data_ring.ring_id; diff --git a/drivers/net/wireless/ath/ath11k/hal_tx.c b/drivers/net/wireless/ath/ath11k/hal_tx.c index cbe549798762..72a51ed65a51 100644 --- a/drivers/net/wireless/ath/ath11k/hal_tx.c +++ b/drivers/net/wireless/ath/ath11k/hal_tx.c @@ -71,6 +71,7 @@ void ath11k_hal_tx_cmd_desc_setup(struct ath11k_base *ab, void *cmd, ti->dscp_tid_tbl_idx) | FIELD_PREP(HAL_TCL_DATA_CMD_INFO3_SEARCH_INDEX, ti->bss_ast_hash); + tcl_cmd->info4 = 0; } /* Commit the descriptor to hardware */ -- 2.20.1