Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1317390ybl; Wed, 4 Dec 2019 22:30:46 -0800 (PST) X-Google-Smtp-Source: APXvYqwXIRRfFBY9LfGv2SWVo4R8Mr6xsO+q2tJR+zQjy5TbzGbgR3Vv56hV/9kd+oAFIBMOXtdE X-Received: by 2002:a05:6808:b18:: with SMTP id s24mr5732092oij.31.1575527446044; Wed, 04 Dec 2019 22:30:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575527446; cv=none; d=google.com; s=arc-20160816; b=pQAeJZhXetNLE2bABOBMr0D02gA9XBMGYoLn9MX16ZU7iBzTIWa6wdqVt2B75xn5fA L9gIBFQ5oiS6HzACPzEMcDroGJXR6R7tOAoxdd30BQeIzQ6PNWB2il5IoeGJVuACun8k +Dx21Rlu5gvc142HcP2Dh64feXFUBQeS/N3Fc4L1yOi/5GIxCJkMjzsf6rLYWyQskuds kphw7fa/c4cQj1wr1qeRDYQmZp6WP+pUPWFYweBMLNfs+mZPs6IIrjOsuKYKSHMY6QlZ +njfTEksge9Ww31Ax3QEsJqB1jg9+N0zKrgQEudJTZ1XDCfHOXYYNorOc5TAQDj654yu do1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=cVPyMzE4dITeqYS+EAb1NyzRuWd37Rwgf4b7ps9Ic7I=; b=hz4WamHiVU0f4Cv4rUcXAJq+mhdH2Bm9DOW6zKMx+lIl5gVPxl1I5heDLnvfnxRaOj /qjLmjV5P1skL+qie/LEL6Cpb7flm59OJpWTh/kpSV6iHb6gPzK7WkOdqrjM9WE4FqNS NgPg7Um384NWeiZ5Qz3BxNd1ybvua6KbppVcphPJARS6465/JmOhC64fJFVzWCa0dXVE MERerqn9O+jkYDnH9l0Acbbfsm768h3Q5x6ahGUrdRVisKS/nUqwtIG7SIxtDrwNQwyq UKuV8cPE9ld3L5igZcz0LrgNmTDUE9vK9bMDebLh+QeugmrESkBfeU7ouAqAXvH+kKg0 +j0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h11si4781779otr.197.2019.12.04.22.30.35; Wed, 04 Dec 2019 22:30:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726177AbfLEG04 (ORCPT + 99 others); Thu, 5 Dec 2019 01:26:56 -0500 Received: from nbd.name ([46.4.11.11]:56164 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725963AbfLEG0z (ORCPT ); Thu, 5 Dec 2019 01:26:55 -0500 Received: from pd95fd3d5.dip0.t-ipconnect.de ([217.95.211.213] helo=bertha.datto.lan) by ds12 with esmtpa (Exim 4.89) (envelope-from ) id 1ickbD-0001bo-4S; Thu, 05 Dec 2019 07:26:51 +0100 From: John Crispin To: Kalle Valo Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, John Crispin Subject: [PATCH 2/2] ath11k: explicitly cast wmi commands to their correct struct type Date: Thu, 5 Dec 2019 07:26:45 +0100 Message-Id: <20191205062645.6033-2-john@phrozen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191205062645.6033-1-john@phrozen.org> References: <20191205062645.6033-1-john@phrozen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Three of the WMI command handlers were not casting to the right data type. Lets make the code consistent with the other handlers. Signed-off-by: John Crispin --- drivers/net/wireless/ath/ath11k/wmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c index a2f03360e19f..0c1064a0aa39 100644 --- a/drivers/net/wireless/ath/ath11k/wmi.c +++ b/drivers/net/wireless/ath/ath11k/wmi.c @@ -2517,7 +2517,7 @@ ath11k_wmi_send_twt_enable_cmd(struct ath11k *ar, u32 pdev_id) if (!skb) return -ENOMEM; - cmd = (void *)skb->data; + cmd = (struct wmi_twt_enable_params_cmd *)skb->data; cmd->tlv_header = FIELD_PREP(WMI_TLV_TAG, WMI_TAG_TWT_ENABLE_CMD) | FIELD_PREP(WMI_TLV_LEN, len - TLV_HDR_SIZE); cmd->pdev_id = pdev_id; @@ -2568,7 +2568,7 @@ ath11k_wmi_send_twt_disable_cmd(struct ath11k *ar, u32 pdev_id) if (!skb) return -ENOMEM; - cmd = (void *)skb->data; + cmd = (struct wmi_twt_disable_params_cmd *)skb->data; cmd->tlv_header = FIELD_PREP(WMI_TLV_TAG, WMI_TAG_TWT_DISABLE_CMD) | FIELD_PREP(WMI_TLV_LEN, len - TLV_HDR_SIZE); cmd->pdev_id = pdev_id; @@ -2768,7 +2768,7 @@ ath11k_wmi_send_obss_spr_cmd(struct ath11k *ar, u32 vdev_id, if (!skb) return -ENOMEM; - cmd = (void *)skb->data; + cmd = (struct wmi_obss_spatial_reuse_params_cmd *)skb->data; cmd->tlv_header = FIELD_PREP(WMI_TLV_TAG, WMI_TAG_OBSS_SPATIAL_REUSE_SET_CMD) | FIELD_PREP(WMI_TLV_LEN, len - TLV_HDR_SIZE); -- 2.20.1