Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2132992ybl; Thu, 5 Dec 2019 12:36:07 -0800 (PST) X-Google-Smtp-Source: APXvYqzdyU4lLqIgGBrmK2ns6CtA5bfFP9WBbl/DjZnCSHxkUtA93LyUGFe5VBUACDaXdTJmtaY7 X-Received: by 2002:aca:5d57:: with SMTP id r84mr9376934oib.42.1575578167168; Thu, 05 Dec 2019 12:36:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575578167; cv=none; d=google.com; s=arc-20160816; b=coxQMeSfaTWZ7k4RiG0Lz1SiFSQFOuUjTaBk5eC45IulYfM11opGuOhY3uGzttkDZa xOQMCphsDpnZW3CWWJTO5jCcZ45XW3qxUiCv71aRJiYHSbsxragjfDBexpVn/3zv53x0 qWQH785ECwgE2XwwN+wYb2OU/P1ny81BiTlCfST/l62h4oF/8EOShcNb06gIcE/UuT0H ziL3nGiv5njWgKOSbtLVTZ+FyydrUkShT5XzVb6NyltaLPlfMJKPRhL69H960oaK0u7R ysUNbkqfaKgDRT8xZvtiPNxwkVJdJ/7qLzHRgEmj519ePKiAT+X/xdGWpjmj7ZmZqL7/ LstA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=LaFIGr5kNkCVjXmVRgweGnjbzeJJUFePEYFBXrNMk1g=; b=jG/2sUKD/u2tnq9Ku0wVLxAvSrZGL7qVN1hvL0EYXKPesZGrrLYkunPDaCxXFvskmO 1frqGEPWB6v3HJrGq7gpLNj+0lL79PfyCbz4HRCN+fPUYItMDKa2bvE9jOXw0Uv8NPWK 0kjegJu+hFkY0ikxRgvuQgLfX7/1WBeYN84s9A5bLvUxzrwKgRWVULTyIK1C8P6J1O9N aA5v0LjbdTyaGxDGjnwR//R+0F1cWI4M3RlQhBSG3z4R+amwYbBqMJa8r9ncwR0UUFyo PDRgS6fFGNSt/cdXMUDIIAiTpQs0GvzSH/utCrXC+DibKOR6u2bto21YH5Cq3PMJIWYU Wjqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m82si5592667oig.129.2019.12.05.12.35.44; Thu, 05 Dec 2019 12:36:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729417AbfLEUf3 (ORCPT + 99 others); Thu, 5 Dec 2019 15:35:29 -0500 Received: from s3.sipsolutions.net ([144.76.43.62]:33240 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729187AbfLEUf3 (ORCPT ); Thu, 5 Dec 2019 15:35:29 -0500 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.3) (envelope-from ) id 1icxqR-004ec7-2i; Thu, 05 Dec 2019 21:35:27 +0100 Message-ID: Subject: Re: debugging TXQs being empty From: Johannes Berg To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= Cc: linux-wireless@vger.kernel.org Date: Thu, 05 Dec 2019 21:35:24 +0100 In-Reply-To: (sfid-20191205_173422_269617_0F8319D0) References: (sfid-20191205_173422_269617_0F8319D0) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, 2019-12-05 at 17:34 +0100, Johannes Berg wrote: > What I think is (part of) the problem is that I see in the logs that our > hardware queues become empty every once a while. I made a histogram of A-MPDU sizes (or singles), and out of the ~11k frames in the log snapshot I took, I see only ~72% full size A-MPDUs (63 subframes, don't remember why now but we never use 64) but ~9.5% singles or A-MPDUs with <10 subframes... The rest is pretty evenly distributed with a small peak (2%) at 62. So looks like I could get much better performance if I was able to keep the queues full, not that I'm any closer to figuring out why they're not ... johannes