Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 9 Dec 2019 04:35:05 +0000
From:   vthiagar@codeaurora.org
To:     John Crispin <john@phrozen.org>
Cc:     Johannes Berg <johannes@sipsolutions.net>,
        Kalle Valo <kvalo@codeaurora.org>,
        linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
        linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH 7/7] ath11k: add handling for BSS color
In-Reply-To: <20191206143401.4080-7-john@phrozen.org>
References: <20191206143401.4080-1-john@phrozen.org>
 <20191206143401.4080-7-john@phrozen.org>
Message-ID: <0101016ee8f07cd1-50bd69b1-8bc0-49ef-a9a3-3e4f0d8dc9d1-000000@us-west-2.amazonses.com>
User-Agent: Roundcube Webmail/1.3.9
Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2019-12-06 20:04, John Crispin wrote:
> This patch adds code to handle the BSS_CHANGED_BSS_COLOR flag. IT will
> trigger the propagation of BSS color settings into the FW. Handling is
> slightly different between AP and STA interfaces.
> 
> Signed-off-by: John Crispin <john@phrozen.org>
> ---
>  drivers/net/wireless/ath/ath11k/mac.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/net/wireless/ath/ath11k/mac.c
> b/drivers/net/wireless/ath/ath11k/mac.c
> index 6a8c1c3b8da2..c692922513b2 100644
> --- a/drivers/net/wireless/ath/ath11k/mac.c
> +++ b/drivers/net/wireless/ath/ath11k/mac.c
> @@ -1928,6 +1928,19 @@ static void
> ath11k_mac_op_bss_info_changed(struct ieee80211_hw *hw,
>  		ath11k_wmi_send_obss_spr_cmd(ar, arvif->vdev_id,
>  					     &info->he_obss_pd);
> 
> +	if (changed & BSS_CHANGED_HE_BSS_COLOR) {
> +		if (vif->type == NL80211_IFTYPE_AP) {
> +			ath11k_wmi_send_obss_color_collision_cfg_cmd(
> +				ar, arvif->vdev_id, info->he_bss_color.color,
> +				ATH11K_BSS_COLOR_COLLISION_DETECTION_AP_PERIOD_MS,
> +				!info->he_bss_color.disabled);

No error code check required, why?

> +		} else if (vif->type == NL80211_IFTYPE_STATION) {
> +			ath11k_wmi_send_bss_color_change_enable_cmd(ar, arvif->vdev_id, 1);
> +			ath11k_wmi_send_obss_color_collision_cfg_cmd(ar, arvif->vdev_id, 0,
> +				ATH11K_BSS_COLOR_COLLISION_DETECTION_STA_PERIOD_MS, 1);

Same here.


Vasanth