Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4499957ybl; Mon, 9 Dec 2019 11:50:13 -0800 (PST) X-Google-Smtp-Source: APXvYqw3VOy56qPye34/S6Wp4vJrWjK+9Eh0oaE5fDpBem7xDjQ+BlSvRoQ716q0LladbbecgClQ X-Received: by 2002:a9d:7ccc:: with SMTP id r12mr23787875otn.22.1575921013864; Mon, 09 Dec 2019 11:50:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575921013; cv=none; d=google.com; s=arc-20160816; b=QcCKIEcNJsYV5jRNyvJkcwv2Fznql/w6sv1gWujZ6bMPTvzaU9zXik/Hy2aMkdt8rJ Lc087OTnkmye+bBVWWrNMDLQvhaWYMP5nIb4Tm8V2rYwd62r4simW29WqdObbLL5XZRv TcjUZGwl6h2D19nOaQavMLJxzk8cspPatqW/pCeII4zS6V7HKs4BjqAXtnaO+22mkNgA RGrt9Se0d9uzNWqxlkNKqV/IZZvc1r8LoRUgkJ3unQ2HcOyqqMUAtfpHyX0JPRTSLVLf na+oGFPOulAHD+OW/n2YL/JN98tIpgb3TTGLKCR/QX1JGUGMBKbu5+SQU8tQRa/KIYgj T8rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:feedback-id:user-agent:message-id :references:in-reply-to:subject:cc:to:from:date :content-transfer-encoding:mime-version:dkim-signature :dkim-signature; bh=dSBGu6PlwJkg2I2NdY4nr+rgt2AHL9falmKV5o0wL28=; b=K4yKtnnVc/icC4pzb1KvdExYVuAyRckXHEuBPjf9U6BMwf+T9Y3Dknr2EFDVKZ/J8L L3gJyR6HJBVxkzzROYeedyJ/LS8V5/ADEcgp6w2dR7lpEtWITU9qX5i2Jf58JMI/aASN 2eTLeJkOaEsROg443o6netHKraV52JZSFC900UPsBYo4XtiPvVRlUur/jPDwNhCxp9CL ZBAiRBIyrFgDCvLl9tBaTOJNFX0qZxWkFpbqVb3JXImSe7wcOrjvMI9430gDKlbSBAJw yjGGkYUlZAjjJ7XJvsavYSYGE8d0DlrzPvBeK/umzxBJZMUy9OINr0qtIFNO80wctExy NqyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=zsmsymrwgfyinv5wlfyidntwsjeeldzt header.b=g+ubyZbd; dkim=pass header.i=@amazonses.com header.s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx header.b="CClNepi/"; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n84si502792oib.157.2019.12.09.11.49.56; Mon, 09 Dec 2019 11:50:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=zsmsymrwgfyinv5wlfyidntwsjeeldzt header.b=g+ubyZbd; dkim=pass header.i=@amazonses.com header.s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx header.b="CClNepi/"; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726509AbfLITr5 (ORCPT + 99 others); Mon, 9 Dec 2019 14:47:57 -0500 Received: from a27-10.smtp-out.us-west-2.amazonses.com ([54.240.27.10]:51956 "EHLO a27-10.smtp-out.us-west-2.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726342AbfLITr4 (ORCPT ); Mon, 9 Dec 2019 14:47:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zsmsymrwgfyinv5wlfyidntwsjeeldzt; d=codeaurora.org; t=1575920876; h=MIME-Version:Content-Type:Content-Transfer-Encoding:Date:From:To:Cc:Subject:In-Reply-To:References:Message-ID; bh=P1m0j0XGFyovvK7fT8FKAKKgAru998yHIVdxJadEKwE=; b=g+ubyZbd9/hmtA4yOkxI083/StHCgDrjCdzkiOjdYLHo0h0liDbPq7yjI78r+2dl EFTPGeipouZYe6+wnGqQn/rdpTUkNApR4Jnl2qzzVzFm/VnF7EACMzAL/nSmlb6byXw hf3OpxdUhmswz7NysKoX1irmFlLQ9jCSohjerW+k= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx; d=amazonses.com; t=1575920876; h=MIME-Version:Content-Type:Content-Transfer-Encoding:Date:From:To:Cc:Subject:In-Reply-To:References:Message-ID:Feedback-ID; bh=P1m0j0XGFyovvK7fT8FKAKKgAru998yHIVdxJadEKwE=; b=CClNepi/3eSzYrXWmTHBZVd1CzN/U2EOIm19lYFNID7XNiBMPcTNHr5blTD+Paup 9G52Vf8jyy13jxBCTCKDQAEpa090yKwCG9AP898VLqumsqKcUsbtdbxpVdfY1NYFMP/ KnyFTePxpVKAXQRXQjVqZcuWnOoi+/LdusMpqvis= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,TVD_SPACE_RATIO autolearn=unavailable autolearn_force=no version=3.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 9 Dec 2019 19:47:56 +0000 From: pradeepc@codeaurora.org To: John Crispin Cc: Kalle Valo , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH V2 8/9] ath11k: optimise ath11k_dp_tx_completion_handler In-Reply-To: <20191204181745.27297-9-john@phrozen.org> References: <20191204181745.27297-1-john@phrozen.org> <20191204181745.27297-9-john@phrozen.org> Message-ID: <0101016eec3439d6-e9a65da0-17a1-48dd-8962-e5c9ded95375-000000@us-west-2.amazonses.com> X-Sender: pradeepc@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-SES-Outgoing: 2019.12.09-54.240.27.10 Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > @@ -828,10 +827,7 @@ void ath11k_dp_free(struct ath11k_base *ab) > ath11k_dp_tx_pending_cleanup, ab); > idr_destroy(&dp->tx_ring[i].txbuf_idr); > spin_unlock_bh(&dp->tx_ring[i].tx_idr_lock); > - > - spin_lock_bh(&dp->tx_ring[i].tx_status_lock); > - kfifo_free(&dp->tx_ring[i].tx_status_fifo); > - spin_unlock_bh(&dp->tx_ring[i].tx_status_lock); > + kfree(&dp->tx_ring[i].tx_status); > } "kfree(&dp->tx_ring[i].tx_status)" --> "kfree(dp->tx_ring[i].tx_status)"