Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 10 Dec 2019 09:21:55 +0100
From:   Greg KH <greg@kroah.com>
To:     Brian Norris <briannorris@google.com>
Cc:     stable <stable@vger.kernel.org>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        sharvari.harisangam@nxp.com,
        Ganapathi Bhat <ganapathi.bhat@nxp.com>
Subject: Re: [REQUEST TO BACKPORT] mwifiex: update set_mac_address logic
Message-ID: <20191210082155.GA3182516@kroah.com>
References: <CA+ASDXPfK7a8RYdg19nga59QwNkovo7Dt2VOqsCa5vLsc2F-SQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+ASDXPfK7a8RYdg19nga59QwNkovo7Dt2VOqsCa5vLsc2F-SQ@mail.gmail.com>
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Mon, Dec 09, 2019 at 05:03:54PM -0800, Brian Norris wrote:
> I'd like to request the following commit [1] go to -stable. It fixes a
> regression (as far back as kernel v4.17) where the default MAC address
> is computed incorrectly. This can have pretty nasty effects when
> upgrading kernels, since people don't expect their HW MAC address to
> change.
> 
> It probably should have had this tag, for the record:
> 
> Fixes: 864164683678 ("mwifiex: set different mac address for
> interfaces with same bss type")
> 
> Thanks,
> Brian
> 
> [1]
> commit 7afb94da3cd8a28ed7ae268143117bf1ac8a3371
> Author: Sharvari Harisangam <sharvari@marvell.com>
> Date:   Wed Jun 12 20:42:11 2019 +0530
> 
>     mwifiex: update set_mac_address logic
> 
>     In set_mac_address, driver check for interfaces with same bss_type
>     For first STA entry, this would return 3 interfaces since all priv's have
>     bss_type as 0 due to kzalloc. Thus mac address gets changed for STA
>     unexpected. This patch adds check for first STA and avoids mac address
>     change. This patch also adds mac_address change for p2p based on bss_num
>     type.
> 
>     Signed-off-by: Sharvari Harisangam <sharvari@marvell.com>
>     Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
>     Signed-off-by: Kalle Valo <kvalo@codeaurora.org

Given this shows up in 5.3, 4.19.y is the only tree it can be applied
to, so I have now done that, thanks.

greg k-h