Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org F0B48C43383
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH v1.2] Revert "iwlwifi: assign directly to iwl_trans->cfg
 in QuZ detection"
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <alpine.DEB.2.21.999.1912021706060.21300@department-of-alchemy.mit.edu>
References: <alpine.DEB.2.21.999.1912021706060.21300@department-of-alchemy.mit.edu>
To:     Anders Kaseorg <andersk@mit.edu>
Cc:     Johannes Berg <johannes.berg@intel.com>,
        Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
        Luca Coelho <luciano.coelho@intel.com>,
        Intel Linux Wireless <linuxwifi@intel.com>,
        linux-wireless@vger.kernel.org
User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12
Message-ID: <0101016eeef0b98e-9251829b-8524-4fb8-8ca2-1d084d532f94-000000@us-west-2.amazonses.com>
Date:   Tue, 10 Dec 2019 08:33:04 +0000
Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Anders Kaseorg <andersk@mit.edu> wrote:

> This reverts commit 968dcfb4905245dc64d65312c0d17692fa087b99.
> 
> Both that commit and commit 809805a820c6445f7a701ded24fdc6bbc841d1e4
> attempted to fix the same bug (dead assignments to the local variable
> cfg), but they did so in incompatible ways. When they were both merged,
> independently of each other, the combination actually caused the bug to
> reappear, leading to a firmware crash on boot for some cards.
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=205719
> 
> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
> Acked-by: Luca Coelho <luciano.coelho@intel.com>

Patch applied to wireless-drivers.git, thanks.

db5cce1afc8d Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ detection"

-- 
https://patchwork.kernel.org/patch/11269985/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches