Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 8/8] arm64: dts: rockchip: RockPro64: enable wifi module
 at sdio0
To:     Kalle Valo <kvalo@codeaurora.org>,
        =?UTF-8?Q?Heiko_St=c3=bcbner?= <heiko@sntech.de>
Cc:     linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        brcm80211-dev-list@cypress.com, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20191209223822.27236-1-smoch@web.de> <2668270.pdtvSLGib8@diego>
 <2cf70216-8d98-4122-4f4e-b8254089a017@web.de> <6162240.GiEx4hqPFh@diego>
 <0101016eef171394-2c71e1b8-45b9-4e38-96f9-2841dd0607ba-000000@us-west-2.amazonses.com>
From:   Soeren Moch <smoch@web.de>
Message-ID: <e8742d18-9dd9-bd97-1d4a-0c5312501b24@web.de>
Date:   Tue, 10 Dec 2019 11:15:58 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.1
MIME-Version: 1.0
In-Reply-To: <0101016eef171394-2c71e1b8-45b9-4e38-96f9-2841dd0607ba-000000@us-west-2.amazonses.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


On 10.12.19 10:14, Kalle Valo wrote:
> Heiko St=C3=BCbner <heiko@sntech.de> writes:
>
>> Hi Soeren,
>>
>> Am Dienstag, 10. Dezember 2019, 00:29:21 CET schrieb Soeren Moch:
>>> On 10.12.19 00:08, Heiko St=C3=BCbner wrote:
>>>> Am Montag, 9. Dezember 2019, 23:38:22 CET schrieb Soeren Moch:
>>>>> RockPro64 supports an Ampak AP6359SA based wifi/bt combo module.
>>>>> The BCM4359/9 wifi controller in this module is connected to sdio0,
>>>>> enable this interface.
>>>>>
>>>>> Signed-off-by: Soeren Moch <smoch@web.de>
>>>>> ---
>>>>> Not sure where to place exactly the sdio0 node in the dts because
>>>>> existing sd nodes are not sorted alphabetically.
>>>>>
>>>>> This last patch in this brcmfmac patch series probably should be pic=
ked
>>>>> up by Heiko independently of the rest of this series. It was sent to=
gether
>>>>> to show how this brcmfmac extension for 4359-sdio support with RSDB =
is
>>>>> used and tested.
>>>> node placement looks good so I can apply it, just a general questions
>>>> I only got patch 8/8 are patches 1-7 relevant for this one and what a=
re they?
>>> Patches 1-7 are the patches to support the BCM4359 chipset with SDIO
>>> interface in the linux brcmfmac net-wireless driver, see [1].
>>>
>>> So this patch series has 2 parts:
>>> patches 1-7: add support for the wifi chipset in the wireless driver,
>>> this has to go through net-wireless
>>> patch 8: enable the wifi module with this chipset on RockPro64, this p=
atch
>> Thanks for the clarification :-) .
>>
>> As patch 8 "only" does the core sdio node, it doesn't really depend on =
the
>> earlier ones and you can submit any uart-hooks for bluetooth once the
>> other patches land I guess.
>>
>>
>>> If this was confusing, what would be the ideal way to post such series=
?
>> I think every maintainer has some slightly different perspective on thi=
s,
>> but personally I like getting the whole series to follow the discussion=
 but
>> also to just see when the driver-side changes get merged, as the dts-pa=
rts
>> need to wait for that in a lot of cases.
> FWIW I prefer the same as Heiko. If I don't see all the patches in the
> patchset I start worrying if patchwork lost them, or something, and then
> it takes more time from me to investigate what happened. So I strongly
> recommend sending the whole series to everyone as it saves time.
>
Thanks for your explanation.
I will keep this in mind for future submissions.

Soeren