Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3F0E3C433A2
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Markus Theil <markus.theil@tu-ilmenau.de>
Cc:     nbd@nbd.name, linux-wireless@vger.kernel.org,
        lorenzo.bianconi@redhat.com, Stanislaw Gruszka <stf_xl@wp.pl>
Subject: Re: [PATCH] mt76: use AC specific reorder timeout
References: <20191209211527.13977-1-markus.theil@tu-ilmenau.de>
Date:   Tue, 10 Dec 2019 10:49:02 +0000
In-Reply-To: <20191209211527.13977-1-markus.theil@tu-ilmenau.de> (Markus
        Theil's message of "Mon, 9 Dec 2019 22:15:27 +0100")
Message-ID: <0101016eef6d37ca-3ecafc5d-7b76-4c84-85e9-8c1388723603-000000@us-west-2.amazonses.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Markus Theil <markus.theil@tu-ilmenau.de> writes:

> Before this patch, mt76 handled rx traffic for all TIDs  equally,
> when released from reorder buffer early. This patch uses an AC specific
> reorder timeout, in order to release partial aggregated frames for voice
> or video ACs earlier. For example, ath10k also uses AC specific reorder
> timeouts (reported by firmware in that case).
>
> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>

[...]

> +static unsigned long mt76_aggr_tid_to_timeo(u8 tidno)
> +{
> +	const int ieee802_1d_to_ac[8] = {

static const?

> +		IEEE80211_AC_BE,
> +		IEEE80211_AC_BK,
> +		IEEE80211_AC_BK,
> +		IEEE80211_AC_BE,
> +		IEEE80211_AC_VI,
> +		IEEE80211_AC_VI,
> +		IEEE80211_AC_VO,
> +		IEEE80211_AC_VO
> +	};
> +	const int ac_to_timeout[] = {

static const?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches