Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp700463ybl; Wed, 11 Dec 2019 06:15:10 -0800 (PST) X-Google-Smtp-Source: APXvYqxJL7aegGeBbB6AADxpOl+JcEFnAn1h5D5bX/aBQsHhSe5fYbMksFwG23/WmAemcigcLUgz X-Received: by 2002:aca:c509:: with SMTP id v9mr2767161oif.151.1576073710015; Wed, 11 Dec 2019 06:15:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576073710; cv=none; d=google.com; s=arc-20160816; b=znp2D4BmXRc8q3u5otO1BLFw/TiK8Caa4N8h+ARSIO0sDtOI45Bkd/2LTcviCx5+Mf 3KhKCrlOQVh0Bce7EonxUO7gAoaTGicb61h5Ut1Bxf7M3viXCpmQJLuV+N3oZbGLgkQe 6UbzByso/+lvUarmeZXjINzwXHnzMvAdAyyMaEPjBrkzxPmg9JuV63WndyubzfY460z3 9RIlDAPUnqgomDV/kMkHAyxtRUNKDtIKR//v35zDDqorwrrh9C8gqWjSjyMGo1ZKGaNT RgFotfmFVJf/gunk3yTxuDyTigAnvfSTwtYwtT8sRevCJlEOqQbrlxbDYiPAdAY3XHwB JZqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=mVLsfpg6y6a8GVwUwqQ94LiTky1EuWvp6yJbXNzd6SM=; b=jsjPJKnfyynAVuGzY6utgvACNqUkdLdwU4hCqA4LjeEIXX8Ls3lVQhw4YfGZcw9TZX hWX3eINY6M+HeU1+RP29DSHKkIlJym4LH/z49RA8RhyHUbjE0Aho0CTIByUYpOxX7471 Cks9C5urk/Q2z9IF65Gq6iW4gdqdXUU6ruOFbwLW+fRphobB225gaQkmPoqBwPajOIO4 AYfx2s78tk00/7AIyXdmJjjgpDHtDq4WYOI5MAAprbdzzi0BOQv6yF/7A7tkzln8EVTg wnlNVupIlf2nKJ6zMTkxqwvSKWNA8vUNbCOzDRvyS8sOIna9CBrJ6oeZqq1sNVvvPvdc aRbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p11si1116422ota.300.2019.12.11.06.14.54; Wed, 11 Dec 2019 06:15:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729780AbfLKONg (ORCPT + 99 others); Wed, 11 Dec 2019 09:13:36 -0500 Received: from s3.sipsolutions.net ([144.76.43.62]:55158 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbfLKONg (ORCPT ); Wed, 11 Dec 2019 09:13:36 -0500 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.3) (envelope-from ) id 1if2k6-004C7H-6n; Wed, 11 Dec 2019 15:13:30 +0100 Message-ID: Subject: Re: iwlwifi warnings in 5.5-rc1 From: Johannes Berg To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , Jens Axboe , Emmanuel Grumbach , Luca Coelho , "Jason A. Donenfeld" , Steve French Cc: "linux-wireless@vger.kernel.org" , Networking Date: Wed, 11 Dec 2019 15:13:29 +0100 In-Reply-To: <87o8wfeyx5.fsf@toke.dk> References: <87o8wfeyx5.fsf@toke.dk> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 2019-12-11 at 15:09 +0100, Toke Høiland-Jørgensen wrote: > > If we're doing this on a per-driver basis, let's make it a proper > NL80211_EXT_FEATURE and expose it to userspace; that way users can at > least discover if it's supported on their device. I can send a patch > adding that... Sure. Just didn't get to that yet, but if you want to send a patch that's very welcome. I have to run out now, will be back in the evening at most. > Maybe we should untangle this from airtime_flags completely, since if we > just use the flags people could conceivably end up disabling it by > mistake, couldn't they? Yes, that sounds like a good plan, now I was wondering why it's there anyway. johannes