Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191211145230.200132-1-toke@redhat.com> <20191211145230.200132-2-toke@redhat.com>
 <df7eb0b71dc9cfdc7d9b5f7abdbcce0d42fa4a1e.camel@sipsolutions.net>
In-Reply-To: <df7eb0b71dc9cfdc7d9b5f7abdbcce0d42fa4a1e.camel@sipsolutions.net>
From:   Justin Capella <justincapella@gmail.com>
Date:   Wed, 11 Dec 2019 22:05:19 -0800
Message-ID: <CAMrEMU9t-Ed9ASyjGcJvpKM=Japiy0fv_cd1_3D5Sy_UMte_9A@mail.gmail.com>
Subject: Re: [PATCH 1/2] mac80211: Turn AQL into an NL80211_EXT_FEATURE
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@redhat.com>,
        linux-wireless@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Disclaimer: I'm new, so don't assume my questions are rhetorical...

sta =3D container_of(txq->sta, struct sta_info, sta); // Is this correct?

I see the use of IEEE80211_NUM_ACS seems to be standard, is that AC
specific? I learned today that different devs have different numbers
of queues...

What are the units of the THRESHOLD, iirc there was some bit shifting/maski=
ng?

Is there supposed to be a queue per station, or just per interface? It
seemed like the threshold was meant to pick a higher or lower queue,
this seems to maybe just reject if not within the bounds?

Sorry for all the questions, I'm still on the gradual side of the learning =
curve


On Wed, Dec 11, 2019 at 1:22 PM Johannes Berg <johannes@sipsolutions.net> w=
rote:
>
> On Wed, 2019-12-11 at 15:52 +0100, Toke H=C3=B8iland-J=C3=B8rgensen wrote=
:
> >
> > diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.=
h
> > index 341e0e8cae46..1e6f435c709c 100644
> > --- a/include/uapi/linux/nl80211.h
> > +++ b/include/uapi/linux/nl80211.h
> > @@ -5563,6 +5563,7 @@ enum nl80211_ext_feature_index {
> >       NL80211_EXT_FEATURE_STA_TX_PWR,
> >       NL80211_EXT_FEATURE_SAE_OFFLOAD,
> >       NL80211_EXT_FEATURE_VLAN_OFFLOAD,
> > +     NL80211_EXT_FEATURE_AQL,
>
> This is missing kernel-doc.
>
> johannes
>