Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <2e5f60bc56e930e599cd5c5ed1925e41dcc90f14.camel@sipsolutions.net>
Subject: Re: [PATCH] mac80211: he_support was not set when bringing up a HE
 mesh interface
From:   Johannes Berg <johannes@sipsolutions.net>
To:     John Crispin <john@phrozen.org>
Cc:     linux-wireless@vger.kernel.org,
        Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
        Sven Eckelmann <seckelmann@datto.com>
Date:   Fri, 13 Dec 2019 10:32:15 +0100
In-Reply-To: <20191213092636.17736-1-john@phrozen.org>
References: <20191213092636.17736-1-john@phrozen.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


> From: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
> 
> The he_support flag inside bss_conf was not set when a HE mesh interface
> gets created. This causes the drivers to not set the HW up correctly.

This is all wrong ... it doesn't even explain the change.

Also, the subject? Really? I know you can all do better.

> Fixes: 60ad72da55ac ("mac80211: implement HE support for mesh")
> 
> Cc: Sven Eckelmann <seckelmann@datto.com>

The fixes should also be part of the footer.

johannes