Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp981984ybl; Fri, 13 Dec 2019 07:39:58 -0800 (PST) X-Google-Smtp-Source: APXvYqymW1sNNFcl6S+Udk+Jaby8hKxyXHiGVvK7FURiKnc1NSefcowBfwMnUsS1Qm6Zm1Y1oIyc X-Received: by 2002:a9d:7a46:: with SMTP id z6mr15673337otm.194.1576251598371; Fri, 13 Dec 2019 07:39:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576251598; cv=none; d=google.com; s=arc-20160816; b=SKldNz2XbJC60+2Y2Fw/Cwjfk2ikgPGk/pTvG+jaHcAgQyWx7BfFwt/C7X3fPc/CNk TEXcdfabOc7D/vkvZckIAGqwjUI/zX6u9JpuUZdhLQean6gQRvlXyielxP2FMtkdvvdo Nyqhv8ljMzto2UJ/hWaZbAUp948HDre9fugOZVdbQ5G7ANMxPTkln3gXW9oyOPRSIYM8 R4NxXeMfAwZgrlYX7zB3/RXTWVwOAhoCauO9KLKHmvX7UDtdECT5j05LtTjTd+2jXOZo wrzYZXWC4EkQ3IPq0h2ObR+uZus5oGUhf/k/hL9qU/dRA+z6HaZxWtFRM0zsJ3wPL9e2 9TrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=AdC7y5Y398mLbr30ogjibNKI+fxF5YyzcSKAsONjyHo=; b=VgBAiDBrVtAt+UyphlAKl8Vj+ZIOExEkDNTgIsoX2xUVDdt7sTBO2L9dXpSV19P93b gWq7f7tY/ZlIqQmntpt7wSSHD1MKAL7NFU/bfGiS685TFZ5No0ky+PsmStaeveAfGKr4 EjrS2D5OvHu/kHVRqTKYIe6miqyk81bUaNFZ7H9Mbt6Kd2TMyPuGKl2pfMKYfQNH6NGH JERrMUqk9tpX1l1+LLuCRecwifskkm24QURfXdGxuTTsDe3/N9LnL1AOxLNbbRefGXeF 1hV+Z3PCBaNa4phun2UmQskttSHBl+fMX2G9Z6b8INtIugsU87JwTwbDOsv9B9hbaXie Be5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 24si5030955oip.248.2019.12.13.07.39.47; Fri, 13 Dec 2019 07:39:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727980AbfLMPio (ORCPT + 99 others); Fri, 13 Dec 2019 10:38:44 -0500 Received: from nbd.name ([46.4.11.11]:54822 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727967AbfLMPio (ORCPT ); Fri, 13 Dec 2019 10:38:44 -0500 Received: from pd95fd344.dip0.t-ipconnect.de ([217.95.211.68] helo=bertha.fritz.box) by ds12 with esmtpa (Exim 4.89) (envelope-from ) id 1ifn1e-0005pC-FD; Fri, 13 Dec 2019 16:38:42 +0100 From: John Crispin To: Kalle Valo Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, John Crispin Subject: [PATCH V3 3/9] ath11k: drop memset when setting up a tx cmd desc Date: Fri, 13 Dec 2019 16:38:33 +0100 Message-Id: <20191213153839.12372-4-john@phrozen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191213153839.12372-1-john@phrozen.org> References: <20191213153839.12372-1-john@phrozen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org There is no point in zero'ing out the structure if we set all values in the following line. Signed-off-by: John Crispin --- drivers/net/wireless/ath/ath11k/dp_tx.c | 2 -- drivers/net/wireless/ath/ath11k/hal_tx.c | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/dp_tx.c b/drivers/net/wireless/ath/ath11k/dp_tx.c index a8b9557c2346..28ebc414533e 100644 --- a/drivers/net/wireless/ath/ath11k/dp_tx.c +++ b/drivers/net/wireless/ath/ath11k/dp_tx.c @@ -167,8 +167,6 @@ int ath11k_dp_tx(struct ath11k *ar, struct ath11k_vif *arvif, skb_cb->vif = arvif->vif; skb_cb->ar = ar; - memset(cached_desc, 0, HAL_TCL_DESC_LEN); - ath11k_hal_tx_cmd_desc_setup(ab, cached_desc, &ti); hal_ring_id = tx_ring->tcl_data_ring.ring_id; diff --git a/drivers/net/wireless/ath/ath11k/hal_tx.c b/drivers/net/wireless/ath/ath11k/hal_tx.c index cbe549798762..72a51ed65a51 100644 --- a/drivers/net/wireless/ath/ath11k/hal_tx.c +++ b/drivers/net/wireless/ath/ath11k/hal_tx.c @@ -71,6 +71,7 @@ void ath11k_hal_tx_cmd_desc_setup(struct ath11k_base *ab, void *cmd, ti->dscp_tid_tbl_idx) | FIELD_PREP(HAL_TCL_DATA_CMD_INFO3_SEARCH_INDEX, ti->bss_ast_hash); + tcl_cmd->info4 = 0; } /* Commit the descriptor to hardware */ -- 2.20.1