Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3099313ybl; Fri, 20 Dec 2019 03:59:08 -0800 (PST) X-Google-Smtp-Source: APXvYqwSrTYKye0ALo9rLu1VtRjI3BNI3EMQB8TCksZ+vuybX2HH1DFJFXBFb/NviNu0OgOfcq+E X-Received: by 2002:a9d:7a97:: with SMTP id l23mr10045425otn.34.1576843148133; Fri, 20 Dec 2019 03:59:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576843148; cv=none; d=google.com; s=arc-20160816; b=f2mPRSNFUVnm8g0raJG8AE8EfaxG5bJKAJLVQXo72CJSo76Mrt+CWXpAYoEBjAgf24 cpaY8vDPHmBdZvPNDldpL7ac/7ECjWBV4Q3OqHBMGyCF/kYHI/liOi13Ljmir+no/nzk cZjeveKlrT/XNsRtZVIPqLgw5Z3jjtyQKvS4DH2CoDP7VS4joapM/qO0PteWwroO+pEB MqEurAM4P4QsmF6WJgH2eHiIujJs1YuUBSau3qYjHl8ZdU/4ARQKUd3G+XxOoca/LGtP jUu0nVhXj/6IXevutvB/UYfOcD+fISl2lo1k63SthZ1ZBxD4NqG5QcbtDA1kPleADevE jpkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:cc:to:from; bh=YZSg/WY7kQWqBNDs7SH7/wZMqi45UG6S34yaPnlCjlQ=; b=iRT9XxyzQe010Qv+pbG9dCDe7iLDGP0ccgE3RlKifc1BgsVoGiuKMVSBwg/WF7Rwec ralI8wh4CPW96l7WQihNyNJPt9ANSf9VpSaEZq8NZwtSvacLdWoRNhoE7glNG6bGoF8l bkGtHyu9ptvj6dHN4VgYx/gEpawijTfqXaNyvM4iysOKLDWURbuIqNNkS5RtyS6CnfgE WqPK/Po+sLZBVpfrCeXAFIbeOzoyKbjCyiUIf49r8gItSYNNC1a3RMWxWCz0HK+i5tPy 4Dz71G3IYimEDudlWRlgmxUijtDYyfj5shlEH6sdIwDpdp+ocQbtdo6rzEbOck0Ww+O9 JtwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q2si2161298otn.220.2019.12.20.03.58.58; Fri, 20 Dec 2019 03:59:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727370AbfLTL4t (ORCPT + 99 others); Fri, 20 Dec 2019 06:56:49 -0500 Received: from paleale.coelho.fi ([176.9.41.70]:53970 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727177AbfLTL4t (ORCPT ); Fri, 20 Dec 2019 06:56:49 -0500 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=redipa.ger.corp.intel.com) by farmhouse.coelho.fi with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.2) (envelope-from ) id 1iiGti-0007ip-HI; Fri, 20 Dec 2019 13:56:47 +0200 From: Luca Coelho To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org Date: Fri, 20 Dec 2019 13:56:32 +0200 Message-Id: <20191220115638.1299888-5-luca@coelho.fi> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191220115638.1299888-1-luca@coelho.fi> References: <20191220115638.1299888-1-luca@coelho.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Subject: [PATCH v5.5 04/10] iwlwifi: pcie: detect the DMA bug and warn if it happens Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Johannes Berg Warn if the DMA bug is going to happen. We don't have a good way of actually aborting in this case and we have workarounds in place for the cases where it happens, but in order to not be surprised add a safety-check and warn. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c b/drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c index b2a3a1c18bec..090c1156bc21 100644 --- a/drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c +++ b/drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c @@ -231,6 +231,17 @@ static int iwl_pcie_gen2_set_tb(struct iwl_trans *trans, int idx = iwl_pcie_gen2_get_num_tbs(trans, tfd); struct iwl_tfh_tb *tb; + /* + * Only WARN here so we know about the issue, but we mess up our + * unmap path because not every place currently checks for errors + * returned from this function - it can only return an error if + * there's no more space, and so when we know there is enough we + * don't always check ... + */ + WARN(crosses_4g_boundary(addr, len), + "possible DMA problem with iova:0x%llx, len:%d\n", + (unsigned long long)addr, len); + if (WARN_ON(idx >= IWL_TFH_NUM_TBS)) return -EINVAL; tb = &tfd->tbs[idx]; -- 2.24.0