Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp13822276ybl; Sun, 29 Dec 2019 21:49:55 -0800 (PST) X-Google-Smtp-Source: APXvYqyRz1y52i05W+t64lvQ3pFiPGb+AfMhVbBMQ0761bIE/RAnhqMsS02L2JG2g7TvOZeY3B1k X-Received: by 2002:a05:6830:1042:: with SMTP id b2mr72629156otp.306.1577684995143; Sun, 29 Dec 2019 21:49:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577684995; cv=none; d=google.com; s=arc-20160816; b=bbPKhrEIIOssRdgdOEtSl7q9yNVm/20PmDAT5t1wJFHAO6YC/y1oFcGBvEz5x/Twy/ ZiSV6ppI/03EbQRAf9V2cMfLqWlJybM69Kq1l7ITwiTqAcdjMj6pqPaPpS9yu3ABV/DR L6EqEBTWlodtVjB9MoHBsmwl8C1Im7hifZjWzLwMGUX515VIMMpzspAO88YwO4zXCnEH WgqlOlS5S0P9oThIVFflQs4t7XD6U+klAkpAI1GMNSshMfz2LQCnDxjfjVO8sItrJB8z ntLtGBFrx3XsiAvFdzjTiqygOcuJ1pknAhkEupJQTXhuYE00jpGWAlzlcg7KvmfmAnbE fucg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=pV9sFnke8XTKtwDdTCz5G0L/lati/L0owkBTHBa2szc=; b=0WsuYVaAx/e4dvRtWHKYIoorz3V59rE4WJZ7CndVRk+cem2ll2s08tVPrN2UVi1AI6 atJQlQlxI2bFyfnvijsi6wfAbV3jdnLlQeLoYA316QXvCYvUNbyuycGv/E7hbPEov6B/ UB5/O7m3RXqLMz+0NfYP3TheA3h8vc59G3pOT7hfTAZZIWVjuV3yFTLi/ypYJ1YzPAvd twTgP0WPpJDILJEpXJLS1Eh7Tmge+JSdUzewLBDlqMMT2j26LhLdxP7+QZTZ9PtfDTtL g1yaZgXiVv0iuRuj1NYGu6bVMSJ6xxfphrnURv1avRAtEP5JCNdLm7p2iJRKKZj3FAa7 M0UA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i205si21413188oih.257.2019.12.29.21.49.32; Sun, 29 Dec 2019 21:49:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727158AbfL3FtK (ORCPT + 99 others); Mon, 30 Dec 2019 00:49:10 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:60860 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727142AbfL3FtK (ORCPT ); Mon, 30 Dec 2019 00:49:10 -0500 Received: from [192.168.9.205] (157-131-199-19.fiber.dynamic.sonic.net [157.131.199.19]) (authenticated bits=0) (User authenticated as andersk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id xBU5mscK010955 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 30 Dec 2019 00:48:57 -0500 Subject: Re: [PATCH AUTOSEL 5.4 056/187] Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ detection" To: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Luca Coelho , Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org References: <20191227174055.4923-1-sashal@kernel.org> <20191227174055.4923-56-sashal@kernel.org> From: Anders Kaseorg Message-ID: <5dbea7a0-5c66-abe4-b1ef-bbfceccbb9bb@mit.edu> Date: Sun, 29 Dec 2019 21:48:53 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20191227174055.4923-56-sashal@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 12/27/19 9:38 AM, Sasha Levin wrote: > From: Anders Kaseorg > > [ Upstream commit db5cce1afc8d2475d2c1c37c2a8267dd0e151526 ] > > This reverts commit 968dcfb4905245dc64d65312c0d17692fa087b99. > > Both that commit and commit 809805a820c6445f7a701ded24fdc6bbc841d1e4 > attempted to fix the same bug (dead assignments to the local variable > cfg), but they did so in incompatible ways. When they were both merged, > independently of each other, the combination actually caused the bug to > reappear, leading to a firmware crash on boot for some cards. > > https://bugzilla.kernel.org/show_bug.cgi?id=205719 > > Signed-off-by: Anders Kaseorg > Acked-by: Luca Coelho > Signed-off-by: Kalle Valo > Signed-off-by: Sasha Levin This commit’s child 0df36b90c47d93295b7e393da2d961b2f3b6cde4 (part of the same bug 205719) is now enqueued for v5.4, but this one doesn’t seem to have made it yet, perhaps because I forgot to Cc: stable@ in the commit message. Can someone make sure this goes to v5.4 as well? Luca previously nominated it for v5.4 here: https://patchwork.kernel.org/patch/11269985/#23032785 Anders