Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp15114137ybl; Tue, 31 Dec 2019 01:36:28 -0800 (PST) X-Google-Smtp-Source: APXvYqwcOGjVlbpT0s71R3FSXOA1G3k38fnYew2+anienlGlLbgYXODtECJnA7EDFm954dHAndee X-Received: by 2002:a9d:4692:: with SMTP id z18mr77057804ote.163.1577784988015; Tue, 31 Dec 2019 01:36:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577784988; cv=none; d=google.com; s=arc-20160816; b=wmVLzTcPwpa7kuy7D9f+E8fd2XcBlWKUGoGigsCxYTE5HGr7WC5onpEVcOs4tcbrLn XRraGa26yfa8fJT/SkAgyTfLAC2rq0LBzurQdFZdWSavi93qBhThZEp9MbH+JDAxWwAc o3fw/DydqD19Ts3T7SYQOOrFrD5PDv048t/0eJT5bgkQ2vcq5k1SSH9tbC9kli3hdFgB G1TUuSIOuUy2QBVOnLcnETyZ2ckRELtxGf2O0w8nWBm0KWupKVGe60GXWQ68AbVV4Jkw 2/5XAk4YeXhwsVlt0eaEqthSqo10bLCdYQIbhyLFjMys8759hUeKHQRiBc2tArCJFgRJ cI1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature; bh=PgBVetFV5i/BVN9CTKkEURi7vaEtzmcR53n7QM3V48k=; b=gQC4j4Tr6Ei1OlQ2tXv8xrkBGn2OmImiGUwocztN8M/1EHQA2PskYvp4JBRlFhQi0P hP4wtoTKas6+llyBT3itUERMvSqdl6VzOx5Ovuo1uPbHXfnm+b3IA5Avki2RJ5m8njsW geflEyFEI9DmBVQUGOHh/bsMCoe6xTQ/0wptphCHsK7GDAn0QrxXa1L9xrBMlOLHLADM 6J+Es3l7DfmyC4MI7UVo/83GY7Puot+vfCqoWfOhwnPY/BRYFmp+D/gRQFOBEzCepS0A ZZYn4U5KxhMT0/670KEzQGWY5HoJIYknzwjdNDd2jUlfgSRL4y0ITH30TkE2TrJRhBxP GCnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=K6tgzazv; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d11si23507383oti.325.2019.12.31.01.36.16; Tue, 31 Dec 2019 01:36:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=K6tgzazv; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725875AbfLaJgQ (ORCPT + 99 others); Tue, 31 Dec 2019 04:36:16 -0500 Received: from mail25.static.mailgun.info ([104.130.122.25]:16592 "EHLO mail25.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725770AbfLaJgQ (ORCPT ); Tue, 31 Dec 2019 04:36:16 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1577784975; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=PgBVetFV5i/BVN9CTKkEURi7vaEtzmcR53n7QM3V48k=; b=K6tgzazvFDTKp1MS2SAjYd4B1LxGVzA7hstXBjVWrYxXzc6gFDFZCj3/bvZckFVel8CFoDP0 VlxK0yFd1RWGdjiwscrjlbaQx6gc+ZTziGS44g6Q/ZffHR+B+OF0t5Ct6+x3yTjYpM41EjqR dDqs9cSGv+2yMr4skmkUjAqpB8U= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e0b168b.7f81591e4e30-smtp-out-n01; Tue, 31 Dec 2019 09:36:11 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 4236AC4479C; Tue, 31 Dec 2019 09:36:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id EDD0DC43383; Tue, 31 Dec 2019 09:36:10 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 31 Dec 2019 17:36:10 +0800 From: wgong@codeaurora.org To: Justin Capella Cc: ath10k , linux-wireless@vger.kernel.org Subject: Re: [PATCH] ath10k: select the min len of RX skb for sdio In-Reply-To: References: <20191220063829.11873-1-wgong@codeaurora.org> Message-ID: X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-12-20 20:11, Justin Capella wrote: > If the data is invalid I think it should be discarded and a warning > displayed, it is just as bad to pass too little data isn't it? Then > you potentially have uninitialized data? Or pointers to nonsense? > There is a good chance I am misunderstanding though, I just wanted to > make sure you had considered those cases and the word alignment if > that applies to this type of bus? yes, patch v2: https://patchwork.kernel.org/patch/11313849/