Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <6be80de69f79ae9b93c5595957f863ea759e177b.camel@sipsolutions.net>
Subject: Re: [PATCH v2 03/10] iwlwifi: pcie: work around DMA hardware bug
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Justin Capella <justincapella@gmail.com>,
        Luca Coelho <luca@coelho.fi>
Cc:     Kalle Valo <kvalo@codeaurora.org>, linux-wireless@vger.kernel.org
Date:   Thu, 02 Jan 2020 10:21:43 +0100
In-Reply-To: <CAMrEMU-qALUNn3njYxomD_2GYUV3MHSTuwjfrC_AFaWybqi3qw@mail.gmail.com> (sfid-20191228_212644_892554_0B0892C8)
References: <20191220115638.1299888-4-luca@coelho.fi>
         <20191223093250.1445654-1-luca@coelho.fi>
         <CAMrEMU-qALUNn3njYxomD_2GYUV3MHSTuwjfrC_AFaWybqi3qw@mail.gmail.com>
         (sfid-20191228_212644_892554_0B0892C8)
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi Justin,

Please trim your quotes and reply appropriately.

On Sat, 2019-12-28 at 12:26 -0800, Justin Capella wrote:
> Would using phys+len & ~dev->dma_mask work in place of the 4g boundary check

No. Look at the value of dma_mask, and the nature of the bug.

johannes